Skip to content

Respect live link target and download attributes on child clicks - #4466

Merged
SteffenDE merged 1 commit into
phoenixframework:mainfrom
lukaszsamson:ls-target-download
Oct 6, 2026
Merged

SteffenDE merged 1 commit into
phoenixframework:mainfrom
lukaszsamson:ls-target-download

Conversation

@lukaszsamson

Copy link
Copy Markdown
Contributor

This PR fixes a following problem: wantsNewTab misses the anchor's target/download attributes if the click is on a child element

<.link patch={...} target="_blank"><span>open</span></.link>

or similar shape with download/named target, clicked on the inner span/icon

@SteffenDE
SteffenDE merged commit 42098dd into phoenixframework:main Oct 6, 2026
4 of 9 checks passed
@SteffenDE

Copy link
Copy Markdown
Member

🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants