curl: Deduplicate features array and fix coding style

[thg2k]

Since 8.4 there are two almost identical copies (minus the sentinel) of the features array.

Being an internal static array, there is no need for the sentinel, thus the related check inside the loop is no longer needed.

Simplifies the code, reduces the size of the compile product, and improves maintainability.

Also, some coding style fixes.

[Girgias]

MSTM but can you split the whitespace changes into a different commit that can be merged separately?

[Girgias]

Please target master as these sort of changes can only land in master.

[thg2k]

Please target master as these sort of changes can only land in master.

I was targeting 8.4 as this is the branch where the "problem" was first introduced. Is there any chance to get it in there, or maybe 8.5?

[Girgias]

You will need to ask RMs for this allowance. @php/release-managers-84 @php/release-managers-85

[DanielEScherzer]

IF this is going to be merged into 8.5 (and maybe also 8.4?) (and I'm not sure it is, need to discuss with the other release managers) please omit the whitespace changes and other no-op tweaks, which don't need to be included in older versions.

Specifically looking at the changes like

• whitespace removal in php_info_print_table_row(2, "cURL support", "enabled");
• spaces being replaced with tabs
• switching 0x073E00 to 0x073e00
  and similar

The simplification to deduplicate the features array is one thing, and that may be worth including in 8.4 and 8.5, but the whitespace cleanup and other tweaks definitely doesn't warrant including in the older branches

[SakiTakamachi]

This is not a critical bug, so personally I would prefer it to be merged into master

[NattyNarwhal]

I agree, it's best to keep cleanups in master unless this is a bugfix (and if so, it should be minimum necessary changes for the sake of patches).