win32/sendmail.c: Various refactorings #20781
Open
+102
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
win-mail-refactor
branch
3 times, most recently
from
f9a22c9 to
7392fa0
Compare
ndossche
requested changes
Dec 26, 2025
Change return type to bool as it only ever returns two values
Girgias
force-pushed
the
win-mail-refactor
branch
from
7392fa0 to
f25c2f6
Compare
Member
Author
|
Done the code changes and renamed some commits. |
ndossche
approved these changes
Dec 26, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Please squash the two separate commits into one that have the same title:
win32/sendmail.c: remove mailBbc parameter that is always NULL
…ters This prevents some strlen() reconputations
It always returns 1 and thus a bunch of error handling code is useless
…eader computation Removes some error handling and work if it fails
This prevents some copying and is in preparation of other refactoring preventing strlen() recomputations
Input as zend_string Use smart_str to concatenate strings Change return type to bool
Girgias
force-pushed
the
win-mail-refactor
branch
from
f25c2f6 to
645d4c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed in order.
This is an initial PR to refactor our email sending code as a lot of unnecessary
strlen()recomputations are happening.