fix duplicated words typos in php codebases #20800
Merged
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LamentXU123
requested review from
TimWolla,
bukka,
derickr,
devnexen,
kocsismate and
zeriyoshi
as code owners
Member
|
Some of these files are bundled libraries (e.g. timelib, uriparser), therefore the fixes should go upstream. And this is why the "verify bundled files" job fails, because those files shouldn't be modified in php-src. |
Contributor
Author
Fixes concerning upstream programs are removed. |
Member
|
date/lib and ext/uri/uriparser should still be reverted. |
Member
|
Thank you @LamentXU123! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I am reading the codebases I found those typos have a relatively high occurrence.
This PR fixes them all. (I don't think we need an issue or emails for this, so I open this PR directly)