ext/intl: Fix grapheme_strstr() and grapheme_strpos() missing canonically equivalent matches - #24029
Merged
Merged
Conversation
Member
|
it seems grapheme_strpos has a similar bug ? |
Member
Author
|
Yeah true. |
LamentXU123
changed the title
Member
|
I think it s worth checking. |
Member
Author
|
Hence if we got an empty haystack we should reject it in php side so we prevent passing it to ICU wdyt? (which is the implementation now) |
Member
|
so it might be best to do it once in |
devnexen
approved these changes
Oct 1, 2026
LamentXU123
added a commit
that referenced
this pull request
Oct 1, 2026
* PHP-8.6: Merge branch 'PHP-8.5' into PHP-8.6 * codex/pr24029-php86: ext/intl: Fix grapheme_strstr() and grapheme_strpos() missing canonically equivalent matches (#24029)
t0ny4
pushed a commit
to t0ny4/php-src
that referenced
this pull request
Oct 1, 2026
* PHP-8.4: ext/intl: Fix grapheme_strstr() and grapheme_strpos() missing canonically equivalent matches (php#24029)
t0ny4
pushed a commit
to t0ny4/php-src
that referenced
this pull request
Oct 1, 2026
* PHP-8.5: Merge branch 'PHP-8.4' into PHP-8.5 * codex/pr24029-php85: ext/intl: Fix grapheme_strstr() and grapheme_strpos() missing canonically equivalent matches (php#24029)
LamentXU123
added a commit
that referenced
this pull request
Oct 1, 2026
Keep master unchanged; the NEWS entry applies to maintenance releases. * PHP-8.6: [skip ci] Merge branch 'PHP-8.5' into PHP-8.6 * codex/pr24029-news-php86: [skip ci] NEWS entry for #24029
ndossche
pushed a commit
to ndossche/php-src
that referenced
this pull request
Oct 1, 2026
ndossche
pushed a commit
to ndossche/php-src
that referenced
this pull request
Oct 1, 2026
* PHP-8.4: [skip ci] NEWS entry for php#24029
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two bugs (and #24028) are the two I immediately spotted after I looked into the code base while fixing #24012. So, there may be more bugs.