Repository navigation
Conversation
adapik
force-pushed
the
openssl-digest-xof-no-length
branch
from
October 2, 2026 15:50
1b01fad to
76af998
Compare
adapik
force-pushed
the
openssl-digest-xof-no-length
branch
from
October 2, 2026 15:50
76af998 to
a5973f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit a warning when
openssl_digest()/openssl_x509_fingerprint()get XOF algorithm without a length.OpenSSL 3.4 removed the default output length of
SHAKE128/256, soEVP_DigestFinal()now fails without an error:openssl_digest('abc', 'shake128')returnsfalsesilently, while on OpenSSL 3.0 it returns 16 bytes. SHAKE128/256 are listed byopenssl_get_md_methods(), so users can reasonably pass them to these functions.Suggested fix: "Unsupported digest algorithm: output length must be specified" when an XOF digest fails. Fixed-length digests and older OpenSSL are unaffected.
Possible follow-up: allow passing $length parameter, if it's ok let me know.