Repository navigation
Don't record non-Variable exprs as conditionally undefined - #6787
Open
vojtech-dobes wants to merge 1 commit into
Open
vojtech-dobes wants to merge 1 commit into
vojtech-dobes wants to merge 1 commit into
Conversation
Contributor
|
please report a new issue and describe whatever you experienced and expectations |
Contributor
Author
@staabm I opened issue and referenced it here with small comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is attempt to fix phpstan/phpstan#15525. If I get the cause right, PHPStan reverted anything not defined locally to its original type. But property obviously isn't defined locally (it's defined on class). So the narrowing of that logic to Variable is hopefully correct solution.
I will be glad for guidance, but the buggy report is nasty :).