Update the repo? - #9
Open
paetling wants to merge 29 commits into
Open
Conversation
Owner
|
Hi @paetling . Sometime back the upstream Apache project (ZooKeeper) took on continued development of the dashboard. See https://issues.apache.org/jira/browse/ZOOKEEPER-701 (notice it kinda morphed into something else...) As a result I haven't been actively developing this project, however I'm happy to pull changes if people are still finding it interesting. I notice immediately that you've removed some important files. The license, readme, etc... I would not feel comfortable merging that change, e.g. removing Apache licensing from the project. Would you be able to review/address and submit a squashed patch? I notice docker support was added, which is quite cool. Adding details on that to the README would be nice. :-) Regards! |
Python 3 compatibility
Added bootstrap dependency Created a base class to allow a common style for everything. Improved navigation with breadcrumbs Tables to definition lists for properties Information links as buttons Other visual improvements
More on python 3 compatibility
Improve style and navigation
* issue: kazoo: error 10038 An operation was attempted on something that is not a socket * please see https://groups.google.com/d/msg/python-zk/EHdF-c_N0OI/6VTWuTHhdnUJ
Fix: Fix kazoo bug on windows platform when viewing znode tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@phunt I stumbled upon this repo last week and decided I wanted to use it to help monitor our zookeeper cluster. I forked the repo and did a bunch of cleanup:
I have some debug statements I need to take out, remove the Dockerfile, and add back in some files, but I was wondering if you were interested in merging these updates back into this repo.