Virtualization V1 #244
Open
Virtualization V1 #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
3 times, most recently
from
6cca062 to
9a479dd
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
945184c to
c878b0b
Compare
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
c878b0b to
e53f541
Compare
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
893431f to
d125f9a
Compare
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
d125f9a to
b786379
Compare
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
e7ed2c2 to
b537069
Compare
Oki! shit's kinda tubin now... * We got dynamic line heights * We got scroll fixing * We theme/wrap switching working too 👀 A lot of this is working pretty well, however I do need to take a pass on getting expanded hunks working
amadeus
force-pushed
the
amadeus/virtualization-v1
branch
from
f02a120 to
8a2b020
Compare
This is a first pass at supporting the expansion situation
It was incorrectly assuming the final hunk hunks.length - 1, when in fact it SHOULD be hunks.length. Classic ruse, I think it managed to fix up all the appropriate areas
Basically in plain text mode, we were using data source for content after
Also fixed the tests and improved the parser
Basically the total counts didn't account for the rest of the file, a big whiff on my part
We were thrashing the elements in a big way in the vanilla js API. No longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature branch to work through supporting virtualization.