-
Notifications
You must be signed in to change notification settings - Fork 34
[experimental] swap the monorepo to use tsgo, oxlint, oxfmt #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
019115f to
5cdc912
Compare
fca4240 to
e06e677
Compare
e06e677 to
2171f6b
Compare
i guess oxfmt currently sorts json Fix diffs tsc errors format undo weird revert of this typecheck all workspaces put husky back cant change the vercel script names yet Restore husky and lint-staged config Add stylelint to lint-staged switch to workspace script commands make docs have a name thats easy to alias in ws dang lockfile latest stuff and undo spurious change format package.json kill duplicate plugin declarations on the lint scripts Add deterministic root typecheck add a script for staged tsc invocations remove duplicate config upgrade bun while we're making things faster kill duplicate tsconfig stuff fix bad deps harden the tsconfig setup maybe more tsconfig hardening build everything first try this try this too undo a lot of stuff but make it work maybe try this for ts failures some debugging more debug roll back some debugging remove more Enable oxfmt import sorting Apply oxfmt import order switch order of aliased imports bump bun again
2171f6b to
7722a5a
Compare
| useLazyDataLoader ? '1' : '0' | ||
| }${cookieSuffix}`; | ||
| }, [flattenEmptyDirectories, useLazyDataLoader]); | ||
| }, [cookieMaxAge, flattenEmptyDirectories, useLazyDataLoader]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actual code change, but it's my demo page, and it's correct.
| return () => { | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| tree.current.setMounted(false); | ||
| instance.setMounted(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another code change but again in file-tree demo
This is a good start for `bun run lint` but my editor doesn't get typeaware linting and i'm not sure how to fix that yet...
big change, trying to go for no code changes though unless very safe seeming (only two or three spots). everything else is config and reordering and new comments and stuff.