Fix master #332
Merged
Fix master #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Will this fix the test problems in #329? |
Member
Author
|
That's my intention, but python is failing to install on macOS, and I can't quite figure out how to get around it. To make things worse, Jenkins macOS builds take AGES, so this is quite time-consuming to debug. :( But yes, |
Merged
Contributor
|
Is there a way to help with this issue? |
Since this has been broken for a while, and it seems non-trivial to fix (or rather, lack of time/interest), allow CI to fail for macOS so we can unfreeze master.
Contributor
|
7425dd7 actually made me lol :D |
Member
Author
|
Opened #335 to track macOS failures separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a flake8 failure. No idea how this got into master.
Also update the changelog, since I had this change just locally, for some reason 🤷♂️