-
Notifications
You must be signed in to change notification settings - Fork 37
consumer: fix EventsGroup memory retention #4057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consumer: fix EventsGroup memory retention #4057
Conversation
Summary of ChangesHello @wlwilliamx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical memory retention issue within the Kafka and Pulsar consumers, which could lead to unbounded memory growth and potential Out-Of-Memory (OOM) errors in long-running workloads. The core solution involves a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses a memory retention issue in the Kafka and Pulsar consumers by introducing a new EventsGroup.ResolveInto method. This method correctly copies out resolved events and clears the pointers in the backing array, preventing the Go garbage collector from retaining flushed DMLEvent objects. The changes are cleanly applied to both kafka-consumer and pulsar-consumer.
Additionally, the PR includes several beneficial log level reductions from INFO/WARN to DEBUG for high-frequency operations, which will help reduce log volume and improve performance under heavy workloads.
The new ResolveInto function is well-documented, and the accompanying unit tests are thorough, covering main functionality and edge cases, ensuring the correctness of the fix and preventing future regressions.
Overall, this is a high-quality contribution that improves the stability and performance of the consumers.
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenfyzhong, wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
* consumer: fix EventsGroup memory retention * add copyright
What problem does this PR solve?
Issue Number: close #4056
What is changed and how it works?
EventsGroup.ResolveIntoto copy out resolved events and clear the resolved prefix pointers before reslicing, avoiding Go GC retention of already-flushedDMLEvents.ResolveIntowhen flushing by watermark or before executing DDL.ResolveIntoto ensure correctness and prevent pointer-retention regressions.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No expected compatibility impact. The additional
clear(...)is O(n) over resolved events and happens on the flush path; it prevents unbounded memory growth and improves stability under long-running workloads.Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note