logservice: fix event store on disk size overflow #4063
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clamp negative Compact.InProgressBytes before casting to uint64 to prevent ticdc_event_store_on_disk_data_size from reporting EiB-scale spikes. Closes pingcap#4062 Signed-off-by: tenfyzhong <[email protected]>
ti-chi-bot
bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/M
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4062
What is changed and how it works?
pebble.Metrics.Compact.InProgressByteswhen calculating event store disk usage to avoid uint64 wraparound.diskSpaceUsage.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No. This only affects metric calculation and adds one conditional check.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note