chore: setup eas ci#2911
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Expo continuous deployment is ready!
|
ApprovabilityVerdict: Approved CI/CD setup for EAS mobile preview builds. Changes are primarily workflow configuration, build profiles, and documentation. The app.config.ts change defaults to existing behavior and only affects CI preview builds. The metro-config patch fixes source map handling at build time. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate adf3d8a
Dismissing prior approval to re-evaluate 21dfc27
21dfc27 to
76d3359
Compare
70ac608 to
a341abd
Compare
79c3a00 to
9a35658
Compare
7fae8cf to
2be5b5d
Compare
2be5b5d to
2234f7a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d122aae. Configure here.
| env: | ||
| APP_VARIANT: preview | ||
| NODE_OPTIONS: --max-old-space-size=8192 | ||
| MOBILE_VERSION_POLICY: fingerprint |
There was a problem hiding this comment.
Missing concurrency can race deploys
Medium Severity
The new EAS preview workflow has no concurrency group for the pull request, so several pushes in quick succession can run overlapping deploy/update jobs against the same pr-<number> branch at once, unlike other PR workflows in this repo that cancel in-progress runs per PR.
Reviewed by Cursor Bugbot for commit d122aae. Configure here.
Dismissing prior approval to re-evaluate d876387
This reverts commit d876387.


What Changed
Setup eas ci
Checklist
Note
Set up EAS CI preview builds for the mobile app
preview:devprofile whenEXPO_TOKENis present; falls back toeas update --no-bytecodeif fingerprint deployment fails.preview:devEAS profile in eas.json withdevelopmentClient=true, internal distribution, APK build type, andMOBILE_VERSION_POLICY=fingerprint.runtimeVersion.policyin app.config.ts configurable viaMOBILE_VERSION_POLICY(defaults toappVersion).@expo/metro-config@56.0.13that strips invalid source map segments before composing maps.Changes since #2911 opened
@expo/metro-configdependency [d122aae]@expo/clidependency from mobile app package [d7a2294]mobile-eas-preview.ymlworkflow [d876387]pnpminstead ofvpas the package manager [f313c1f]Macroscope summarized 2234f7a.
Note
Medium Risk
Touches CI secrets and automated Expo deploys plus a patched Metro bundler dependency; no app auth or data-layer changes, but failed or misconfigured previews could affect reviewer access to PR builds.
Overview
Adds automated mobile PR previews via a new workflow (
.github/workflows/mobile-eas-preview.yml) that runs only whenEXPO_TOKENis set: checks out the repo, sets up Vite+/pnpm/EAS, pulls preview env vars, and deploys withexpo/expo-github-action/continuous-deploy-fingerprintusing profilepreview:dev, branchpr-<number>, andMOBILE_VERSION_POLICY=fingerprint.Introduces the
preview:devEAS profile (preview variant + dev client, internal APK on Android, fingerprint runtime policy) and wiresruntimeVersion.policyinapp.config.tstoMOBILE_VERSION_POLICY(still defaults toappVersionlocally/production). Addseas:ios/android:preview:devscripts and documents the CI fingerprint flow in the mobile README.Adds
.fingerprintignoreso fingerprints ignore build dirs, tests, docs, and local env files. Patches@expo/metro-config@56.0.13to sanitize invalid Hermes/Metro source-map segments before@jridgewell/remappingcomposition (registered inpnpm-workspace.yaml/ lockfile). Also pins@babel/plugin-transform-react-jsx@7.28.6at the repo root.Reviewed by Cursor Bugbot for commit f313c1f. Bugbot is set up for automated code reviews on this repo. Configure here.