Skip to content

chore: setup eas ci#2911

Merged
juliusmarminge merged 13 commits into
mainfrom
yash/eas-ci
Jun 4, 2026
Merged

chore: setup eas ci#2911
juliusmarminge merged 13 commits into
mainfrom
yash/eas-ci

Conversation

@Yash-Singh1
Copy link
Copy Markdown
Collaborator

@Yash-Singh1 Yash-Singh1 commented Jun 2, 2026

What Changed

Setup eas ci

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Set up EAS CI preview builds for the mobile app

  • Adds a pull request workflow that deploys an Expo EAS preview using the new preview:dev profile when EXPO_TOKEN is present; falls back to eas update --no-bytecode if fingerprint deployment fails.
  • Adds the preview:dev EAS profile in eas.json with developmentClient=true, internal distribution, APK build type, and MOBILE_VERSION_POLICY=fingerprint.
  • Makes the runtimeVersion.policy in app.config.ts configurable via MOBILE_VERSION_POLICY (defaults to appVersion).
  • Adds a patch to @expo/metro-config@56.0.13 that strips invalid source map segments before composing maps.
  • Adds a .fingerprintignore to exclude build artifacts, tests, and local env files from Expo fingerprinting.

Changes since #2911 opened

  • Added patch configuration for @expo/metro-config dependency [d122aae]
  • Replaced manual EAS CLI installation with official Expo GitHub Action in mobile preview workflow [d7a2294]
  • Removed error handling and fallback deployment logic from mobile preview workflow [d7a2294]
  • Removed @expo/cli dependency from mobile app package [d7a2294]
  • Changed package manager configuration in mobile-eas-preview.yml workflow [d876387]
  • Configured the mobile EAS preview workflow to use pnpm instead of vp as the package manager [f313c1f]

Macroscope summarized 2234f7a.


Note

Medium Risk
Touches CI secrets and automated Expo deploys plus a patched Metro bundler dependency; no app auth or data-layer changes, but failed or misconfigured previews could affect reviewer access to PR builds.

Overview
Adds automated mobile PR previews via a new workflow (.github/workflows/mobile-eas-preview.yml) that runs only when EXPO_TOKEN is set: checks out the repo, sets up Vite+/pnpm/EAS, pulls preview env vars, and deploys with expo/expo-github-action/continuous-deploy-fingerprint using profile preview:dev, branch pr-<number>, and MOBILE_VERSION_POLICY=fingerprint.

Introduces the preview:dev EAS profile (preview variant + dev client, internal APK on Android, fingerprint runtime policy) and wires runtimeVersion.policy in app.config.ts to MOBILE_VERSION_POLICY (still defaults to appVersion locally/production). Adds eas:ios/android:preview:dev scripts and documents the CI fingerprint flow in the mobile README.

Adds .fingerprintignore so fingerprints ignore build dirs, tests, docs, and local env files. Patches @expo/metro-config@56.0.13 to sanitize invalid Hermes/Metro source-map segments before @jridgewell/remapping composition (registered in pnpm-workspace.yaml / lockfile). Also pins @babel/plugin-transform-react-jsx@7.28.6 at the repo root.

Reviewed by Cursor Bugbot for commit f313c1f. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: dd5e59fa-c330-423c-b27f-c0f0101ebf65

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yash/eas-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jun 2, 2026
Comment thread .github/workflows/mobile-eas-preview.yml
Comment thread .github/workflows/mobile-eas-preview.yml
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

🚀 Expo continuous deployment is ready!

  • Project → t3-code
  • Platforms → android, ios
  • Scheme → t3code-preview
  🤖 Android 🍎 iOS
Fingerprint 251694208975e82c56bd5289d014d27db782d79c 88f9ec34318a3522ac20299028ec60ca0080a665
Build Details Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Update Details Update Permalink
DetailsBranch: pr-2911
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
Git commit: 8df62907d94c789a6f8009cce96c22fd5373b242
Update Permalink
DetailsBranch: pr-2911
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
Git commit: 8df62907d94c789a6f8009cce96c22fd5373b242
Update QR

@Yash-Singh1 Yash-Singh1 marked this pull request as ready for review June 2, 2026 18:28
Comment thread apps/mobile/README.md Outdated
Comment thread .github/workflows/mobile-eas-preview.yml Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 2, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Jun 2, 2026

Approvability

Verdict: Approved

CI/CD setup for EAS mobile preview builds. Changes are primarily workflow configuration, build profiles, and documentation. The app.config.ts change defaults to existing behavior and only affects CI preview builds. The metro-config patch fixes source map handling at build time.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp Bot dismissed their stale review June 2, 2026 18:43

Dismissing prior approval to re-evaluate adf3d8a

Comment thread .github/workflows/mobile-eas-preview.yml Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 2, 2026
@macroscopeapp macroscopeapp Bot dismissed their stale review June 2, 2026 22:30

Dismissing prior approval to re-evaluate 21dfc27

Comment thread package.json
Comment thread patches/@expo%2Fmetro-config@56.0.13.patch
@juliusmarminge juliusmarminge force-pushed the yash/eas-ci branch 2 times, most recently from 70ac608 to a341abd Compare June 4, 2026 02:28
Comment thread .github/workflows/mobile-eas-preview.yml
@juliusmarminge juliusmarminge force-pushed the yash/eas-ci branch 3 times, most recently from 79c3a00 to 9a35658 Compare June 4, 2026 02:44
@juliusmarminge juliusmarminge force-pushed the yash/eas-ci branch 3 times, most recently from 7fae8cf to 2be5b5d Compare June 4, 2026 02:57
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d122aae. Configure here.

Comment thread .github/workflows/mobile-eas-preview.yml Outdated
env:
APP_VARIANT: preview
NODE_OPTIONS: --max-old-space-size=8192
MOBILE_VERSION_POLICY: fingerprint
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing concurrency can race deploys

Medium Severity

The new EAS preview workflow has no concurrency group for the pull request, so several pushes in quick succession can run overlapping deploy/update jobs against the same pr-<number> branch at once, unlike other PR workflows in this repo that cancel in-progress runs per PR.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d122aae. Configure here.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 4, 2026
@macroscopeapp macroscopeapp Bot dismissed their stale review June 4, 2026 05:01

Dismissing prior approval to re-evaluate d876387

@juliusmarminge juliusmarminge merged commit dca93d0 into main Jun 4, 2026
14 checks passed
@juliusmarminge juliusmarminge deleted the yash/eas-ci branch June 4, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants