fix(release): use workspace electron-builder for desktop packaging#2938
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Build tooling change that switches electron-builder from dlx (download on-the-fly) to a workspace dependency. The script and lockfile changes are mechanical, affecting only how the desktop app is packaged during CI, not runtime behavior. You can customize Macroscope's approvability policy. Learn more. |
1f63890 to
052c9e4
Compare
Dismissing prior approval to re-evaluate 052c9e4
|
🚀 Expo continuous deployment is ready!
|
…ingdotgg#2938) Co-authored-by: Julius Marminge <julius@mac.lan> (cherry picked from commit 6a1c4da)
Summary
electron-builder@26.8.1as an explicitapps/desktopdev dependency.vp exec --filter @t3tools/desktop -- electron-builder --projectDir <stage app>instead ofvp dlx electron-builder.package.jsonand build config.Why
The new release logs from https://github.com/pingdotgg/t3code/actions/runs/26931004313/job/79450756574 showed NSIS failing here:
The file exists in
app-builder-lib@26.8.1, but thevp dlxpnpm cache path on Windows is very long and transient. Using the desktop package's installed electron-builder gives NSIS a stable install path while still packaging the staged app via--projectDir.Validation
vp exec --filter @t3tools/desktop -- electron-builder --versionapp-builder-libcontainstemplates/nsis/include/StdUtils.nshvp run --filter scripts typecheckvp run --filter scripts test -- build-desktop-artifact.test.tsvp checkvp run typecheckNote
Use workspace electron-builder for desktop packaging via
pnpm execelectron-builder@26.8.1as a dependency in apps/desktop/package.json so it is available through the workspace toolchain.buildDesktopArtifactin scripts/build-desktop-artifact.ts to runpnpm exec --filter @t3tools/desktop -- electron-builderfrom the repo root instead ofpnpm dlx electron-builderfrom the staged app directory, passing--projectDirexplicitly to point at the staged directory.Macroscope summarized 052c9e4.