Skip to content

fix(release): use workspace electron-builder for desktop packaging#2938

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/fix-release-windows-electron-builder
Jun 4, 2026
Merged

fix(release): use workspace electron-builder for desktop packaging#2938
juliusmarminge merged 1 commit into
mainfrom
codex/fix-release-windows-electron-builder

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Jun 4, 2026

Summary

  • Add electron-builder@26.8.1 as an explicit apps/desktop dev dependency.
  • Run the desktop packager through vp exec --filter @t3tools/desktop -- electron-builder --projectDir <stage app> instead of vp dlx electron-builder.
  • Keep the generated staged app as electron-builder's project directory, so packaging still reads the staged package.json and build config.

Why

The new release logs from https://github.com/pingdotgg/t3code/actions/runs/26931004313/job/79450756574 showed NSIS failing here:

!include: could not find: ...\pnpm-cache\dlx\...\app-builder-lib\templates\nsis\include\StdUtils.nsh

The file exists in app-builder-lib@26.8.1, but the vp dlx pnpm cache path on Windows is very long and transient. Using the desktop package's installed electron-builder gives NSIS a stable install path while still packaging the staged app via --projectDir.

Validation

  • vp exec --filter @t3tools/desktop -- electron-builder --version
  • verified workspace app-builder-lib contains templates/nsis/include/StdUtils.nsh
  • vp run --filter scripts typecheck
  • vp run --filter scripts test -- build-desktop-artifact.test.ts
  • vp check
  • vp run typecheck

Note

Use workspace electron-builder for desktop packaging via pnpm exec

  • Adds electron-builder@26.8.1 as a dependency in apps/desktop/package.json so it is available through the workspace toolchain.
  • Changes buildDesktopArtifact in scripts/build-desktop-artifact.ts to run pnpm exec --filter @t3tools/desktop -- electron-builder from the repo root instead of pnpm dlx electron-builder from the staged app directory, passing --projectDir explicitly to point at the staged directory.

Macroscope summarized 052c9e4.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3b32cc53-425e-4b9b-ac6d-e933ec4fe61a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-release-windows-electron-builder

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Jun 4, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 4, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Jun 4, 2026

Approvability

Verdict: Approved

Build tooling change that switches electron-builder from dlx (download on-the-fly) to a workspace dependency. The script and lockfile changes are mechanical, affecting only how the desktop app is packaged during CI, not runtime behavior.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge force-pushed the codex/fix-release-windows-electron-builder branch from 1f63890 to 052c9e4 Compare June 4, 2026 05:08
@macroscopeapp macroscopeapp Bot dismissed their stale review June 4, 2026 05:08

Dismissing prior approval to re-evaluate 052c9e4

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🚀 Expo continuous deployment is ready!

  • Project → t3-code
  • Platforms → android, ios
  • Scheme → t3code-preview
  🤖 Android 🍎 iOS
Fingerprint 251694208975e82c56bd5289d014d27db782d79c 88f9ec34318a3522ac20299028ec60ca0080a665
Build Details Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Update Details Update Permalink
DetailsBranch: pr-2938
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
Git commit: 669d53f29cb737952f531f0756e0db00d475e028
Update Permalink
DetailsBranch: pr-2938
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
Git commit: 669d53f29cb737952f531f0756e0db00d475e028
Update QR

@juliusmarminge juliusmarminge merged commit 6a1c4da into main Jun 4, 2026
14 checks passed
@juliusmarminge juliusmarminge deleted the codex/fix-release-windows-electron-builder branch June 4, 2026 05:15
J-Giggles pushed a commit to J-Giggles/t3code that referenced this pull request Jun 6, 2026
…ingdotgg#2938)

Co-authored-by: Julius Marminge <julius@mac.lan>
(cherry picked from commit 6a1c4da)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant