[codex] remove duplicated pnpm root config#2939
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🚀 Expo continuous deployment is ready!
|
0c9580a to
fd15c7b
Compare
ApprovabilityVerdict: Approved This PR removes duplicated pnpm workspace configuration from package.json and consolidates it in pnpm-workspace.yaml, while adding a shared YAML parsing utility for build scripts. Changes are limited to internal tooling and include appropriate test coverage. You can customize Macroscope's approvability policy. Learn more. |
fd15c7b to
e58544b
Compare
What changed
package.json(workspaces,overrides, andpatchedDependencies).@t3tools/shared/schemaYaml, a single-file SchemaGetter/SchemaTransformation-based YAML helper with parse/stringify getters and schema decoding support.pnpm-workspace.yamlto use the shared schema helper.yaml: "catalog:"so Effect and the rest of the workspace resolve the sameyamlversion.Why
The pnpm workspace config now lives in
pnpm-workspace.yaml, so keeping duplicate rootpackage.jsonfields risks drift. The sync/build scripts also needed to stop depending on local ad hoc YAML parsing and use a reusable schema-based parser.Validation
vp test run packages/shared/src/schemaYaml.test.ts scripts/sync-reference-repos.test.tsvp check(passes with existing lint warnings)vp run typecheckcorepack pnpm installcorepack pnpm list yaml -r --depth 20reports onlyyaml 2.9.0find node_modules/.pnpm -maxdepth 1 -type d -name 'yaml@*'reports onlyyaml@2.9.0Note
Remove duplicated pnpm root config and add YAML schema decoding support
workspaces,catalog,overrides, andpatchedDependenciesfrom the root package.json, consolidating these into pnpm-workspace.yaml.@t3tools/shared/schemaYamlmodule (schemaYaml.ts) withfromYamlandfromYamlStringschema constructors that decode/encode YAML strings with structured error mapping.readWorkspaceConfigin both apps/server/scripts/cli.ts and scripts/build-desktop-artifact.ts to validate parsed YAML against aSchema.Structinstead of casting the raw parse result.effect-smolin scripts/lib/reference-repos.ts to read its version frompnpm-workspace.yamlvia the new YAML decoder rather than from apackage.json.Macroscope summarized e58544b.