Skip to content

[codex] remove duplicated pnpm root config#2939

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/remove-duplicated-pnpm-config
Jun 4, 2026
Merged

[codex] remove duplicated pnpm root config#2939
juliusmarminge merged 1 commit into
mainfrom
codex/remove-duplicated-pnpm-config

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Jun 4, 2026

What changed

  • Removed pnpm workspace configuration duplicated in the root package.json (workspaces, overrides, and patchedDependencies).
  • Added @t3tools/shared/schemaYaml, a single-file SchemaGetter/SchemaTransformation-based YAML helper with parse/stringify getters and schema decoding support.
  • Updated all repo-local YAML parsing of pnpm-workspace.yaml to use the shared schema helper.
  • Added a workspace override for yaml: "catalog:" so Effect and the rest of the workspace resolve the same yaml version.
  • Adjusted sync tests and a stale desktop build diagnostic message to point at the workspace YAML config.

Why

The pnpm workspace config now lives in pnpm-workspace.yaml, so keeping duplicate root package.json fields risks drift. The sync/build scripts also needed to stop depending on local ad hoc YAML parsing and use a reusable schema-based parser.

Validation

  • vp test run packages/shared/src/schemaYaml.test.ts scripts/sync-reference-repos.test.ts
  • vp check (passes with existing lint warnings)
  • vp run typecheck
  • corepack pnpm install
  • corepack pnpm list yaml -r --depth 20 reports only yaml 2.9.0
  • find node_modules/.pnpm -maxdepth 1 -type d -name 'yaml@*' reports only yaml@2.9.0

Note

Remove duplicated pnpm root config and add YAML schema decoding support

Macroscope summarized e58544b.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3eed7ef9-f86f-456f-9499-cd9a5ac9357f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/remove-duplicated-pnpm-config

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jun 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🚀 Expo continuous deployment is ready!

  • Project → t3-code
  • Platforms → android, ios
  • Scheme → t3code-preview
  🤖 Android 🍎 iOS
Fingerprint 251694208975e82c56bd5289d014d27db782d79c 88f9ec34318a3522ac20299028ec60ca0080a665
Build Details Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Update Details Update Permalink
DetailsBranch: pr-2939
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
Git commit: 7ece907465c30a006e7603d72acae3f2ec1a9f64
Update Permalink
DetailsBranch: pr-2939
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
Git commit: 7ece907465c30a006e7603d72acae3f2ec1a9f64
Update QR

@juliusmarminge juliusmarminge marked this pull request as ready for review June 4, 2026 05:22
@juliusmarminge juliusmarminge force-pushed the codex/remove-duplicated-pnpm-config branch from 0c9580a to fd15c7b Compare June 4, 2026 05:22
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jun 4, 2026
@juliusmarminge juliusmarminge marked this pull request as draft June 4, 2026 05:23
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Jun 4, 2026

Approvability

Verdict: Approved

This PR removes duplicated pnpm workspace configuration from package.json and consolidates it in pnpm-workspace.yaml, while adding a shared YAML parsing utility for build scripts. Changes are limited to internal tooling and include appropriate test coverage.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge force-pushed the codex/remove-duplicated-pnpm-config branch from fd15c7b to e58544b Compare June 4, 2026 05:30
@juliusmarminge juliusmarminge marked this pull request as ready for review June 4, 2026 05:31
@juliusmarminge juliusmarminge enabled auto-merge (squash) June 4, 2026 05:32
@juliusmarminge juliusmarminge merged commit 37bf0f0 into main Jun 4, 2026
18 checks passed
@juliusmarminge juliusmarminge deleted the codex/remove-duplicated-pnpm-config branch June 4, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant