[codex] split ci workflow jobs#2940
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
6c0ab76 to
003da4d
Compare
Contributor
|
🚀 Expo continuous deployment is ready!
|
003da4d to
7525999
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Check,Test, andTest Browserjobs so they can run in parallel.Checklane withvp checkandvpr typecheck.yamldependency for@t3tools/scripts, which is required byscripts/build-desktop-artifact.tsduring typecheck.Why
The previous
qualityjob serialized formatting/linting, typechecking, tests, browser tests, and desktop build work in one CI lane. Splitting these into independent jobs reduces PR feedback time while keeping the same validation coverage.The
yamldependency declaration keeps workspace package metadata accurate and prevents package-scoped type resolution failures.Validation
vp checkpassed with existing nested-component lint warnings.vp run typecheckpassed..github/workflows/ci.ymlwith theyamlpackage.Note
Split CI workflow into separate check, test, and browser test jobs
qualityjob tocheckand adds a desktop build step (vp run build:desktop) plus a preload bundle verification step forapps/desktop/dist-electron/preload.cjstestjob that sets up the Electron runtime and runs unit tests viavp run testtest_browserjob that restores a Playwright browser cache and runs browser tests inapps/webvp run typechecktovpr typecheckin thecheckjobMacroscope summarized 7525999.
Note
Low Risk
CI orchestration and package metadata only; no runtime product or security logic changes.
Overview
Replaces the monolithic
qualityCI job with three parallel jobs—check,test, andtest_browser—so formatting/lint, unit tests, and Playwright runs can finish sooner without dropping coverage.The
checkjob still runsvp check, desktop build, and preload bundle assertions; typecheck is nowvpr typecheckinstead ofvp run typecheck. Playwright browser caching and install steps live only undertest_browser.@t3tools/scriptsdeclaresyamlas a dependency (used when parsing workspace YAML during desktop build/typecheck).Reviewed by Cursor Bugbot for commit 7525999. Bugbot is set up for automated code reviews on this repo. Configure here.