Skip to content

[codex] split ci workflow jobs#2940

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/split-ci-jobs
Jun 4, 2026
Merged

[codex] split ci workflow jobs#2940
juliusmarminge merged 1 commit into
mainfrom
codex/split-ci-jobs

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Jun 4, 2026

What changed

  • Split the main CI workflow into separate Check, Test, and Test Browser jobs so they can run in parallel.
  • Kept desktop build and preload verification in the Check lane with vp check and vpr typecheck.
  • Moved Playwright browser cache/runtime setup into the browser-test lane.
  • Declared the missing yaml dependency for @t3tools/scripts, which is required by scripts/build-desktop-artifact.ts during typecheck.

Why

The previous quality job serialized formatting/linting, typechecking, tests, browser tests, and desktop build work in one CI lane. Splitting these into independent jobs reduces PR feedback time while keeping the same validation coverage.

The yaml dependency declaration keeps workspace package metadata accurate and prevents package-scoped type resolution failures.

Validation

  • vp check passed with existing nested-component lint warnings.
  • vp run typecheck passed.
  • Parsed .github/workflows/ci.yml with the yaml package.

Note

Split CI workflow into separate check, test, and browser test jobs

  • Renames the top-level quality job to check and adds a desktop build step (vp run build:desktop) plus a preload bundle verification step for apps/desktop/dist-electron/preload.cjs
  • Adds a new test job that sets up the Electron runtime and runs unit tests via vp run test
  • Adds a new test_browser job that restores a Playwright browser cache and runs browser tests in apps/web
  • Changes the typecheck command from vp run typecheck to vpr typecheck in the check job

Macroscope summarized 7525999.


Note

Low Risk
CI orchestration and package metadata only; no runtime product or security logic changes.

Overview
Replaces the monolithic quality CI job with three parallel jobs—check, test, and test_browser—so formatting/lint, unit tests, and Playwright runs can finish sooner without dropping coverage.

The check job still runs vp check, desktop build, and preload bundle assertions; typecheck is now vpr typecheck instead of vp run typecheck. Playwright browser caching and install steps live only under test_browser. @t3tools/scripts declares yaml as a dependency (used when parsing workspace YAML during desktop build/typecheck).

Reviewed by Cursor Bugbot for commit 7525999. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2f3f7425-ff89-4b29-8abe-2d2b2acec0c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/split-ci-jobs

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🚀 Expo continuous deployment is ready!

  • Project → t3-code
  • Platforms → android, ios
  • Scheme → t3code-preview
  🤖 Android 🍎 iOS
Fingerprint 251694208975e82c56bd5289d014d27db782d79c 88f9ec34318a3522ac20299028ec60ca0080a665
Build Details Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Update Details Update Permalink
DetailsBranch: pr-2940
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
Git commit: 4e49dcf25383730653fc39cb6d1c5e46db3a94af
Update Permalink
DetailsBranch: pr-2940
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
Git commit: 4e49dcf25383730653fc39cb6d1c5e46db3a94af
Update QR

@juliusmarminge juliusmarminge marked this pull request as ready for review June 4, 2026 05:57
@juliusmarminge juliusmarminge merged commit 4c262c4 into main Jun 4, 2026
17 of 18 checks passed
@juliusmarminge juliusmarminge deleted the codex/split-ci-jobs branch June 4, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant