fix(release): install dependency closures in partial jobs#2941
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🚀 Expo continuous deployment is ready!
|
ApprovabilityVerdict: Approved This PR makes a minor CI/CD configuration change, adding pnpm dependency closure syntax ( You can customize Macroscope's approvability policy. Learn more. |
Summary
pkg...) for release jobs that run repo scripts after partial installs.actions/setup-nodestep fromPublish CLI to npm;setup-vpalready resolves Node frompackage.jsonand sets it up.Why
The latest release run got all desktop builds green, including Windows, then failed in
Publish CLI to npmwhile runningscripts/update-release-package-versions.ts:The job had installed
@t3tools/scriptsand linked@t3tools/shared, but the partial install did not include@t3tools/shared's own dependency links. Installing the selected package dependency closure fixes that class of partial-install runtime failure for publish/release/deploy/finalize/announce jobs.Validation
.github/workflowsno longer referencesactions/setup-nodevp pm list --filter '@t3tools/scripts...' --depth=0includes@t3tools/sharedandeffectvp checkvp run typecheckNote
Low Risk
CI-only install filter and redundant Node setup changes; no runtime app or auth logic touched.
Overview
Release workflow partial installs now use dependency-closure filters (
--filter=pkg...) instead of single-package filters, so jobs that run repo scripts (e.g.update-release-package-versions.ts) get transitive deps likeeffectfor@t3tools/shared. This applies across publish CLI, GitHub release, deploy web, finalize, and Discord announce steps.Publish CLI to npm drops the extra
actions/setup-nodestep;setup-vpalready provisions Node frompackage.json.Reviewed by Cursor Bugbot for commit 932b0de. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Install dependency closures in partial release jobs by appending
...to pnpm filter selectorsUpdates release.yml to append
...to package filter selectors (e.g.--filter=t3...) so that pnpm installs the full dependency closure, not just the named package. Also removes a redundantactions/setup-node@v6step with an npm registry URL from the affected job.Macroscope summarized 932b0de.