Skip to content

fix(release): install dependency closures in partial jobs#2941

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/fix-release-partial-install-deps
Jun 4, 2026
Merged

fix(release): install dependency closures in partial jobs#2941
juliusmarminge merged 1 commit into
mainfrom
codex/fix-release-partial-install-deps

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Jun 4, 2026

Summary

  • Use dependency-closure filters (pkg...) for release jobs that run repo scripts after partial installs.
  • Remove the redundant actions/setup-node step from Publish CLI to npm; setup-vp already resolves Node from package.json and sets it up.

Why

The latest release run got all desktop builds green, including Windows, then failed in Publish CLI to npm while running scripts/update-release-package-versions.ts:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'effect' imported from packages/shared/src/schemaJson.ts

The job had installed @t3tools/scripts and linked @t3tools/shared, but the partial install did not include @t3tools/shared's own dependency links. Installing the selected package dependency closure fixes that class of partial-install runtime failure for publish/release/deploy/finalize/announce jobs.

Validation

  • confirmed .github/workflows no longer references actions/setup-node
  • vp pm list --filter '@t3tools/scripts...' --depth=0 includes @t3tools/shared and effect
  • vp check
  • vp run typecheck

Note

Low Risk
CI-only install filter and redundant Node setup changes; no runtime app or auth logic touched.

Overview
Release workflow partial installs now use dependency-closure filters (--filter=pkg...) instead of single-package filters, so jobs that run repo scripts (e.g. update-release-package-versions.ts) get transitive deps like effect for @t3tools/shared. This applies across publish CLI, GitHub release, deploy web, finalize, and Discord announce steps.

Publish CLI to npm drops the extra actions/setup-node step; setup-vp already provisions Node from package.json.

Reviewed by Cursor Bugbot for commit 932b0de. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Install dependency closures in partial release jobs by appending ... to pnpm filter selectors

Updates release.yml to append ... to package filter selectors (e.g. --filter=t3...) so that pnpm installs the full dependency closure, not just the named package. Also removes a redundant actions/setup-node@v6 step with an npm registry URL from the affected job.

Macroscope summarized 932b0de.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 01ce4b13-9b10-4f0e-94e6-5e3fe6eab4e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-release-partial-install-deps

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jun 4, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) June 4, 2026 05:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🚀 Expo continuous deployment is ready!

  • Project → t3-code
  • Platforms → android, ios
  • Scheme → t3code-preview
  🤖 Android 🍎 iOS
Fingerprint 251694208975e82c56bd5289d014d27db782d79c 88f9ec34318a3522ac20299028ec60ca0080a665
Build Details Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Update Details Update Permalink
DetailsBranch: pr-2941
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
Git commit: 73d3f650d26c5e44cb924e7356c25e8b6e8591d9
Update Permalink
DetailsBranch: pr-2941
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
Git commit: 73d3f650d26c5e44cb924e7356c25e8b6e8591d9
Update QR

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Jun 4, 2026

Approvability

Verdict: Approved

This PR makes a minor CI/CD configuration change, adding pnpm dependency closure syntax (...) to filter flags in the release workflow. The change ensures partial jobs properly install dependencies and doesn't alter deployment targets or production behavior.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit 4f3d00f into main Jun 4, 2026
14 checks passed
@juliusmarminge juliusmarminge deleted the codex/fix-release-partial-install-deps branch June 4, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant