fix(release): preserve desktop artifact arch#2943
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
ApprovabilityA prior Macroscope approval was dismissed. Re-evaluating 8cfea9d… |
Contributor
|
🚀 Expo continuous deployment is ready!
|
7162ab1 to
8cfea9d
Compare
Dismissing prior approval to re-evaluate 8cfea9d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--before the desktop artifact args in the release workflowWhy
vp runforwards args after the script name. The release workflow was invokingvp run dist:desktop:artifact -- "${args[@]}", which made the artifact script itself receive a literal standalone--. Effect CLI then stopped parsing flags after that separator, so the macOS x64 job ignored--arch x64, defaulted to the arm64 host arch, and uploaded arm64 artifacts as the x64 artifact. The GitHub release manifest merge later failed on duplicate arm64 entries.Validation
vp run dist:desktop:artifact --helpshows the script helpvp run dist:desktop:artifact -- --helpreproduces the broken behavior by ignoring--helpand running the default buildvp checkvp run typecheckNote
Low Risk
Single-line CI invocation fix; no runtime app or auth changes.
Overview
Fixes the release workflow Build desktop artifact step so platform/target/arch flags are actually passed through to
dist:desktop:artifact.The step previously ran
vp run dist:desktop:artifact -- "${args[@]}", which forwarded options after a bare--intonode scripts/build-desktop-artifact.tsin a way the Effect CLI did not apply. Matrix values like--arch x64were ignored, so macOS x64 jobs could build the host default (arm64) and mislabel release assets.It now invokes
vp run dist:desktop:artifact "${args[@]}"without the extra--, so signing and verbose flags in the sameargsarray reach the build script as intended.Reviewed by Cursor Bugbot for commit 8cfea9d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix desktop artifact architecture preservation in release workflow
Removes the standalone
--argument separator from thevp run dist:desktop:artifactcommand in release.yml. The separator was causing the arch args to be passed incorrectly, preventing the desktop artifact architecture from being preserved.Macroscope summarized 8cfea9d.