Skip to content

fix(release): preserve desktop artifact arch#2943

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/fix-release-macos-x64-artifacts
Jun 4, 2026
Merged

fix(release): preserve desktop artifact arch#2943
juliusmarminge merged 1 commit into
mainfrom
codex/fix-release-macos-x64-artifacts

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Jun 4, 2026

Summary

  • remove the extra standalone -- before the desktop artifact args in the release workflow

Why

vp run forwards args after the script name. The release workflow was invoking vp run dist:desktop:artifact -- "${args[@]}", which made the artifact script itself receive a literal standalone --. Effect CLI then stopped parsing flags after that separator, so the macOS x64 job ignored --arch x64, defaulted to the arm64 host arch, and uploaded arm64 artifacts as the x64 artifact. The GitHub release manifest merge later failed on duplicate arm64 entries.

Validation

  • vp run dist:desktop:artifact --help shows the script help
  • vp run dist:desktop:artifact -- --help reproduces the broken behavior by ignoring --help and running the default build
  • vp check
  • vp run typecheck

Note

Low Risk
Single-line CI invocation fix; no runtime app or auth changes.

Overview
Fixes the release workflow Build desktop artifact step so platform/target/arch flags are actually passed through to dist:desktop:artifact.

The step previously ran vp run dist:desktop:artifact -- "${args[@]}", which forwarded options after a bare -- into node scripts/build-desktop-artifact.ts in a way the Effect CLI did not apply. Matrix values like --arch x64 were ignored, so macOS x64 jobs could build the host default (arm64) and mislabel release assets.

It now invokes vp run dist:desktop:artifact "${args[@]}" without the extra --, so signing and verbose flags in the same args array reach the build script as intended.

Reviewed by Cursor Bugbot for commit 8cfea9d. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix desktop artifact architecture preservation in release workflow

Removes the standalone -- argument separator from the vp run dist:desktop:artifact command in release.yml. The separator was causing the arch args to be passed incorrectly, preventing the desktop artifact architecture from being preserved.

Macroscope summarized 8cfea9d.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f13a7735-af19-4c91-8220-9661fb56c182

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-release-macos-x64-artifacts

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jun 4, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Jun 4, 2026

Approvability

A prior Macroscope approval was dismissed. Re-evaluating 8cfea9d

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🚀 Expo continuous deployment is ready!

  • Project → t3-code
  • Platforms → android, ios
  • Scheme → t3code-preview
  🤖 Android 🍎 iOS
Fingerprint 251694208975e82c56bd5289d014d27db782d79c 88f9ec34318a3522ac20299028ec60ca0080a665
Build Details Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Update Details Update Permalink
DetailsBranch: pr-2943
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
Git commit: 560a61bfdb62b3c50187af9825f490d79279317d
Update Permalink
DetailsBranch: pr-2943
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
Git commit: 560a61bfdb62b3c50187af9825f490d79279317d
Update QR

@juliusmarminge juliusmarminge force-pushed the codex/fix-release-macos-x64-artifacts branch from 7162ab1 to 8cfea9d Compare June 4, 2026 06:27
@macroscopeapp macroscopeapp Bot dismissed their stale review June 4, 2026 06:27

Dismissing prior approval to re-evaluate 8cfea9d

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Jun 4, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) June 4, 2026 06:28
@juliusmarminge juliusmarminge merged commit 52ae8e8 into main Jun 4, 2026
16 checks passed
@juliusmarminge juliusmarminge deleted the codex/fix-release-macos-x64-artifacts branch June 4, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant