Skip to content

[codex] Avoid shell for Node executable spawns#2952

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/node-spawns-no-shell
Jun 4, 2026
Merged

[codex] Avoid shell for Node executable spawns#2952
juliusmarminge merged 1 commit into
mainfrom
codex/node-spawns-no-shell

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Jun 4, 2026

Summary

Removes Windows shell mode from launches that execute Node itself.

Details

  • Test peers now spawn through process.execPath, which is the current Node executable path and does not require shell lookup.
  • The server CLI build step already used process.execPath; this removes the stale shell flag/comment from that direct Node invocation.
  • Nearby npm and provider/agent command launches are intentionally left shell-backed because they may resolve through .cmd shims on Windows.

Validation

  • vp check passed. It reported existing react(no-unstable-nested-components) warnings outside this change.
  • vp run typecheck passed.

Note

Replace hardcoded node string with process.execPath for child process spawns

Replaces the string "node" with process.execPath and removes the Windows-only shell mode option in all ChildProcess.make calls across the build script and test utilities. This ensures the correct Node binary is used at runtime rather than relying on PATH resolution.

Macroscope summarized 2a8ff34.


Note

Low Risk
Test and build-only spawn options; no auth, data, or production runtime behavior beyond more reliable Node invocation on Windows.

Overview
Child process spawns that run Node directly now use process.execPath instead of the node command and no longer pass shell: true on Windows.

The server build CLI already invoked Node via process.execPath; this drops the leftover Windows shell option and comment from that ChildProcess.make call. ACP and Codex app-server integration tests spawn mock peers the same way, so tests use the current Node binary without shell-based PATH lookup.

npm publish and other launches that may resolve .cmd shims on Windows are unchanged and still use shell mode where needed.

Reviewed by Cursor Bugbot for commit 2a8ff34. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7b03f9ed-ff36-4e23-be10-89e0179e2699

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/node-spawns-no-shell

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jun 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🚀 Expo continuous deployment is ready!

  • Project → t3-code
  • Platforms → android, ios
  • Scheme → t3code-preview
  🤖 Android 🍎 iOS
Fingerprint 251694208975e82c56bd5289d014d27db782d79c 88f9ec34318a3522ac20299028ec60ca0080a665
Build Details Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Update Details Update Permalink
DetailsBranch: pr-2952
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
Git commit: 5db095ff8bde2ee7b30a92af330ec092f81af703
Update Permalink
DetailsBranch: pr-2952
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
Git commit: 5db095ff8bde2ee7b30a92af330ec092f81af703
Update QR

@juliusmarminge juliusmarminge marked this pull request as ready for review June 4, 2026 22:14
@juliusmarminge juliusmarminge merged commit a74dfd4 into main Jun 4, 2026
15 of 16 checks passed
@juliusmarminge juliusmarminge deleted the codex/node-spawns-no-shell branch June 4, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant