Skip to content

Conversation

@philipch07
Copy link
Contributor

Description

  • Updates param_reconfig_response to conform to RFC 6525 since it just needed some optional fields
  • Adds tests to ensure that it's correct

Reference issue

Resolves #418.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.94%. Comparing base (a69c6a2) to head (898ffcd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   83.84%   83.94%   +0.10%     
==========================================
  Files          51       51              
  Lines        3448     3470      +22     
==========================================
+ Hits         2891     2913      +22     
  Misses        417      417              
  Partials      140      140              
Flag Coverage Δ
go 83.94% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeTurki JoeTurki requested a review from Copilot November 2, 2025 05:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for optional fields in SCTP reconfiguration response parameters according to RFC 6525. The implementation now handles the optional Sender's Next TSN and Receiver's Next TSN fields that were previously not supported.

  • Added support for optional senderNextTSN and receiverNextTSN fields in paramReconfigResponse
  • Implemented marshaling and unmarshaling logic to handle variable-length parameter values (8, 12, or 16 bytes)
  • Added validation to ensure receiverNextTSN is only present when senderNextTSN is present

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
param_reconfig_response.go Extended struct with optional fields, updated marshal/unmarshal to handle variable lengths, added validation and new error types
param_reconfig_response_test.go Added comprehensive tests for optional fields including roundtrip tests, validation tests, and renamed existing test function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@philipch07 philipch07 force-pushed the pch07/update-param-reconfig-response-6525 branch from 29ed51d to aeb9ded Compare November 2, 2025 05:37
@philipch07 philipch07 force-pushed the pch07/update-param-reconfig-response-6525 branch from aeb9ded to 898ffcd Compare November 2, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update param_reconfig_response.go to RFC 6525

2 participants