Update param_outgoing_reset_request to RFC 6525 #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 83.84% 83.87% +0.03%
==========================================
Files 51 51
Lines 3448 3455 +7
==========================================
+ Hits 2891 2898 +7
Misses 417 417
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances validation and testing for SCTP Outgoing SSN Reset Request parameters by adding length validation for malformed stream identifier lists and verifying the marshal/unmarshal length formula according to RFC 6525.
- Added validation to reject parameters with odd-length stream identifier lists (which would violate the 2-byte-per-stream-ID requirement)
- Improved documentation with RFC references and clearer comments
- Added comprehensive test coverage for edge cases and length validation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| param_outgoing_reset_request.go | Added validation check for odd-length stream lists, improved comments with RFC references, and refactored unmarshal logic for clarity |
| param_outgoing_reset_request_test.go | Added test cases for invalid odd-length stream lists and marshal/unmarshal length formula verification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference issue
Resolves #420.