Skip to content

Conversation

@SunofCoder
Copy link
Contributor

Added start/stop buttons for DataChannel

  • Improved logging for ICE connection states
  • Fixed DataChannel send errors on stop
  • Updated frontend UI with timestamps and styles

How to test:

  1. Run go run main.go in examples/trickle-ice
  2. Open http://localhost:8080
  3. Start/stop DataChannel and observe ICE state changes

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.05%. Comparing base (a4c8b34) to head (27a8f9b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3258      +/-   ##
==========================================
+ Coverage   84.02%   84.05%   +0.02%     
==========================================
  Files          80       80              
  Lines        9041     9041              
==========================================
+ Hits         7597     7599       +2     
+ Misses       1024     1022       -2     
  Partials      420      420              
Flag Coverage Δ
go 84.05% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, sorry this took too long, will need to fix the lint and rebase (i can get to do that once i have free time).
thank you again.

@JoeTurki JoeTurki force-pushed the fix/trickle-ice-ui branch 2 times, most recently from 89ea35a to a8703c7 Compare November 16, 2025 03:21
start/stop, DataChannel, ICE logs
@JoeTurki JoeTurki merged commit 27a8f9b into pion:master Nov 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants