Skip to content

Conversation

@sforward
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues -

@husmen73
Copy link

@pionl have to approve this changes.

"illuminate/filesystem": "5.2 - 5.8 | ^6.0 | ^7.0 | ^8.0 | ^9.0 | ^10.0 | ^11.0 | ^12.0"
},
"require-dev": {
"phpunit/phpunit": "5.7 | 6.0 | 7.0 | 7.5 | 8.4 | ^8.5 | ^9.3 | ^10.0 | ^11.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you add the phpunit/phpunit package (version ^12.0)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That version is also possible but not required to run the tests for Laravel 12.

@curkan
Copy link

curkan commented Mar 14, 2025

@pionl please merge, everyone is waiting

@HlaingMinThan
Copy link

@pionl can you review and merge ?

@christiangalicia
Copy link

ya se tardaron

@kayedspace kayedspace mentioned this pull request Mar 16, 2025
@pionl
Copy link
Owner

pionl commented Mar 19, 2025

@sforward thank you for the update. All tests passed.

❯ node tests.js "12.*"
Running tests for laravel-chunk-upload-example
Something unexpected? Use --verbose to se all output

🚀 Running tests for 12.* image version: 8.2-node-20
💪 Running docker compose -f docker-compose.yml -f docker-compose-tests.yml up --abort-on-container-exit --build
🎉️‍ ️Done

🚀 Running tests for 12.* image version: 8.3-node-22
💪 Running docker compose -f docker-compose.yml -f docker-compose-tests.yml up --abort-on-container-exit --build
🎉️‍ ️Done

🚀 Running tests for 12.* image version: 8.4-node-22
💪 Running docker compose -f docker-compose.yml -f docker-compose-tests.yml up --abort-on-container-exit --build
🎉️‍ ️Done

🎉 All tests passed

@pionl pionl merged commit 41b5c15 into pionl:master Mar 19, 2025
6 checks passed
@sforward sforward deleted the chore/laravel-12 branch March 19, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants