Skip to content

docs(contributing): expand contribution guidelines with new sections#6399

Merged
eeshaanSA merged 18 commits intopipe-cd:masterfrom
mohammedfirdouss:docs/expand-contributing-pipecd
Feb 2, 2026
Merged

docs(contributing): expand contribution guidelines with new sections#6399
eeshaanSA merged 18 commits intopipe-cd:masterfrom
mohammedfirdouss:docs/expand-contributing-pipecd

Conversation

@mohammedfirdouss
Copy link
Contributor

  • Expand contributing.md with community, dev setup, and PR process
  • Rename "Contributing" to "Contribute to PipeCD"
  • Apply changes to docs-dev and docs-v1.0.x

Addresses #6124

…and details

Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this @mohammedfirdouss!

I checked the files, and while they look good, what do you think of making some more structural changes (better flow of data and sections), and also some more info on how to setup the a local dev guide? The reference to CONTRIBUTING.md is fine, but the CONTRIBUTING.md itself is outdated, so it is better to just have all the information in one page on the website.

@mohammedfirdouss
Copy link
Contributor Author

mohammedfirdouss commented Jan 4, 2026

Hey, thanks for this @mohammedfirdouss!

I checked the files, and while they look good, what do you think of making some more structural changes (better flow of data and sections), and also some more info on how to setup the a local dev guide? The reference to CONTRIBUTING.md is fine, but the CONTRIBUTING.md itself is outdated, so it is better to just have all the information in one page on the website.

Thanks for the feedback @eeshan! Hmm, Okay the website docs page should be self-contained rather than referencing CONTRIBUTING.md.

TO-DO

  • Better structured sections with clear flow
  • Complete local dev setup guide inline (Control Plane, Piped agent, port-forwarding, etc.)
  • Full PR process details instead of just linking to CONTRIBUTING.md

@eeshaanSA This should address the issue already yeah? I am open to feedbacks

…ty engagement details

Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mohammedfirdouss.

Thanks a lot for your contributions! 🚀

@mohammedfirdouss
Copy link
Contributor Author

LGTM, @mohammedfirdouss.

Thanks a lot for your contributions! 🚀

Thank you for the reviews as well @eeshaanSA. Ready for more contributions!

@eeshaanSA eeshaanSA added area/docs approved ready-to-merge PRs that are marked ready to merge by ORG Members and removed ready-to-merge PRs that are marked ready to merge by ORG Members labels Jan 7, 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also change the file names to contributing-to-pipecd.md or something similar. contributing.md looks vague.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this should be straightforward like you say but i feel the naming might be to long

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, but it is better to keep things clear, because we might need more pages here in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, i have made a change to this effect.

Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be nitpicking, but @mohammedfirdouss, what do you think about 'Join the Community' section being repositioned somewhere at the bottom? Would love to know your thoughts!

Copy link
Contributor Author

@mohammedfirdouss mohammedfirdouss Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me. Moving Join the Community to the bottom should focus on how to contribute first, and people can find community links after.

Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move "Join the Community"before "Whats next, in my opinion, and,

you changed only the docs-dev file. You forgot about v1.

Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
@mohammedfirdouss
Copy link
Contributor Author

We can move "Join the Community"before "Whats next, in my opinion, and,

you changed only the docs-dev file. You forgot about v1.

They should have similar structure now @eeshaanSA

## What Happens Next?

The maintainers will review your PR. We'll help with obvious issues and work with you to get it merged. Thank you for contributing!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mohammedfirdouss, maybe you misunderstood the placement of Join the Community. Let's place it at the bottom end for both the files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh!,apologies for that @eeshaanSA. Thanks!

Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
eeshaanSA
eeshaanSA previously approved these changes Jan 13, 2026
Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything looks good now, @mohammedfirdouss. Thanks!

Let the maintainers merge, and then if we find anything later, we can change it.

@mohammedfirdouss
Copy link
Contributor Author

I think everything looks good now, @mohammedfirdouss. Thanks!

Let the maintainers merge, and then if we find anything later, we can change it.

Alright @eeshaanSA. Thanks for the reviews!

mohammedfirdouss and others added 2 commits January 14, 2026 00:40
@mohammedfirdouss
Copy link
Contributor Author

@eeshaanSA In the meeting, Khan said I should rename the files, so docs/content/en/docs-dev/contribution-guidelines/contributing.md retains its name and the other goes to docs/content/en/docs-v1.0.x/contribution-guidelines/contributing-to-pipecd.md

Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.07%. Comparing base (41552f1) to head (a3c2b76).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6399      +/-   ##
==========================================
+ Coverage   28.79%   37.07%   +8.28%     
==========================================
  Files         557       75     -482     
  Lines       59769     6500   -53269     
==========================================
- Hits        17211     2410   -14801     
+ Misses      41246     3952   -37294     
+ Partials     1312      138    -1174     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes ?
.-pkg-app-pipedv1-plugin-kubernetes_multicluster ?
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (?)
.-pkg-app-pipedv1-plugin-terraform 38.65% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 33.92% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 52.71% <ø> (ø)
.-pkg-plugin-sdk 50.34% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mohammedfirdouss mohammedfirdouss requested a review from a team as a code owner January 27, 2026 08:53
Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@eeshaanSA eeshaanSA enabled auto-merge (squash) February 2, 2026 08:18
@eeshaanSA eeshaanSA merged commit 1c045f7 into pipe-cd:master Feb 2, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants