fix: preservation of Tags assigned to CloudRun during deployments#6455
fix: preservation of Tags assigned to CloudRun during deployments#6455kartikangiras wants to merge 2 commits intopipe-cd:masterfrom
Conversation
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
eeshaanSA
left a comment
There was a problem hiding this comment.
Hey @kartikangiras, thanks for this! Was an issue opened for this?
We always advise opening issues first and discussing the problem before raising a PR. This OSS practice helps us keep things uncluttered.
Please link existing issue (if any), or create a new one. Thanks!
@eeshaanSA Issue #4954 was already listed, for which I have proposed this Pull Request. |
|
@khanhtc1202 @Warashi ptal |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
What this PR does:
It ensures tags assigned to CloudRun revisions stay preserved during deployments.
Why we need it:
The problem was that when deploying new revisions, PipeCD was removing tags that were previously assigned to existing CloudRun revisions.
Which issue(s) this PR fixes:
Fixes #4954
Proof Manifests:
Does this PR introduce a user-facing change?: