-
Notifications
You must be signed in to change notification settings - Fork 233
docs: add preview feature functionality with GitHub workflows #6471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ed1389b to
6b34046
Compare
|
@eeshaanSA Please take a look. In case of any changes to make, let me know. |
f60cd49 to
4b86daa
Compare
- Add docs preview check workflow - Add docs preview deploy workflow - Add docs preview cleanup workflow Signed-off-by: antedotee <soniyadav2051982@gmail.com>
Signed-off-by: antedotee <soniyadav2051982@gmail.com>
4b86daa to
38c311e
Compare
eeshaanSA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antedotee, looks good on the first look. I will have to dive into the details of each file. Give me some time, I will get it reviewed.
|
Sorry for asking again😅, but did you have a look at this? |
| name: Docs Preview Check | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this run on pull_request_target for consistent behavior on forks?
| - name: Setup Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '14' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this run on pull_request_target for consistent behavior on forks? Node 14 is EOL and is not supported but gh actions
What this PR does:
This PR generates a github preview if the changes are made solely in the docs folder and generates a deployed website if the branch is prefixed with
docs-. The automation also added the deployed website which is made using gh pages in the PR description.Why we need it:
For better PR review velocity for maintainers
Which issue(s) this PR fixes:
Fixes #6467
I have tested the functionality locally on a seperate repo and it is working as expected. To make this work, after merging and the first workflow run, the pages settings of the repo will have to change to select gh pages from the list of branches (I have added a screenshot below for reference):
