load_paths deprecated for autoload_paths in 2.3.12 - #12
Open
kalleth wants to merge 2 commits into
Open
Conversation
added 2 commits
August 4, 2011 21:28
warning. Per mattdb (cells) commit @ mattdb/cells@ab1541b
authors source tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 2.3.12 deprecates load_paths in favour of autoload_paths which pretty much causes a shedload of deprecation warnings when using desert. This patch fixes it, and isn't -too- hacky.
I was a bit wary about checking if autoload_paths exists at every call, so I pushed it into another protected method. This seems to have fixed it for me.
I also fixed the gemspec as it wouldn't build correctly with me using Bundler - it expected MIT-LICENSE not MIT.LICENSE as exists in the source tree.
First pull request on github - be nice! :)