Skip to content

Enable ICU locale provider in PG build#21

Closed
christopherpestano wants to merge 11 commits into
pixeltable:mainfrom
christopherpestano:utf-8
Closed

Enable ICU locale provider in PG build#21
christopherpestano wants to merge 11 commits into
pixeltable:mainfrom
christopherpestano:utf-8

Conversation

@christopherpestano

@christopherpestano christopherpestano commented Apr 22, 2026

Copy link
Copy Markdown

No description provided.

christopherpestano and others added 4 commits April 21, 2026 17:46
- Bump postgres to 16.11
- Fix linting and formatting issues
- Add missing type hints
- Some refactoring
- Replace Union/Optional with Python 3.10+ syntax
- Bump postgres to 16.11
- Fix linting and formatting issues
- Add missing type hints
- Some refactoring
- Replace Union/Optional with Python 3.10+ syntax
@christopherpestano christopherpestano changed the title Changing PgServer to use UTF-8 Encoding Changing PgServer to use UTF-8 Locale Apr 22, 2026
@aaron-siegel

Copy link
Copy Markdown
Collaborator

I'd suggest adding a unit test to validate this change (i.e., a test that fails without --locale specified but now succeeds)

@christopherpestano christopherpestano changed the title Changing PgServer to use UTF-8 Locale Enable ICU locale provider in PG build (phase 1 of 2) Apr 23, 2026
@christopherpestano christopherpestano changed the title Enable ICU locale provider in PG build (phase 1 of 2) Enable ICU locale provider in PG build Apr 23, 2026
@christopherpestano
christopherpestano marked this pull request as draft April 24, 2026 18:21
@christopherpestano
christopherpestano marked this pull request as ready for review April 24, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants