Print output from the CCScript compiler if there is any#347
Open
PhoenixBound wants to merge 1 commit into
Open
Print output from the CCScript compiler if there is any#347PhoenixBound wants to merge 1 commit into
PhoenixBound wants to merge 1 commit into
Conversation
Currently, the CCScript compiler's output is only printed if an error occurs and compilation completely fails. This commit changes that to print the output in the success case, too. This solves the problem of the CCScript compiler issuing warnings for certain behaviors and the user being completely unable to see the warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the CCScript compiler's output is only printed if an error occurs and compilation completely fails. This PR changes that to print the output in the success case, too. This solves the problem of the CCScript compiler issuing warnings for certain behaviors and the user being completely unable to see the warnings.
There are many people who want certain CCScript things to be an error, partly because of this issue (and partly because they should eventually be made errors). Invalid characters in control code byte sections, and extra ignored parts of expression blocks in springs, have caused a lot of people annoyance. Hopefully this change allows people to identify and fix those issues before we make anything a hard error.