Skip to content

Add extraLabels to both subcontroller and vbsc pods#735

Open
jdoupe wants to merge 4 commits intoplanetscale:mainfrom
jdoupe:add-extra-labels
Open

Add extraLabels to both subcontroller and vbsc pods#735
jdoupe wants to merge 4 commits intoplanetscale:mainfrom
jdoupe:add-extra-labels

Conversation

@jdoupe
Copy link
Copy Markdown
Contributor

@jdoupe jdoupe commented Nov 26, 2025

Fixes #736

By adding the following:
vitessbackupschedules.spec.extraLabels
vitessbackupstorages.spec.extraLabels
vitessclusters.spec.backup.extraLabels

For vtbackup(-init), the code has just been modified to pass along the existing extraLabels on the tabletPool.

@mattlord / @frouioui

@mattlord
Copy link
Copy Markdown
Collaborator

mattlord commented Dec 1, 2025

@jdoupe can you please create a quick issue that describes what problem you're trying to solve? And link it to the PR here. Thanks!

@jdoupe jdoupe force-pushed the add-extra-labels branch 2 times, most recently from c7ba815 to ce2285c Compare December 3, 2025 03:26
@jdoupe
Copy link
Copy Markdown
Contributor Author

jdoupe commented Dec 3, 2025

Administrative note: (and you're probably already aware) the backup-schedule-test failed previously. I made a blank comment adjustment and force-pushed, and it then passed. I guess some sort of race condition.

@mattlord mattlord self-requested a review December 4, 2025 03:49
Copy link
Copy Markdown
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple of tiny nits. Thanks, @jdoupe !

@mattlord mattlord requested a review from frouioui December 5, 2025 15:15
@jdoupe
Copy link
Copy Markdown
Contributor Author

jdoupe commented Feb 2, 2026

Bump @frouioui

Copy link
Copy Markdown
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! The operator manifest and the vitess repository will need to be modified given this PR updates the CRDs. A guide on how to do this is available here:

#629 (comment)

jdoupe added 3 commits April 4, 2026 12:07
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
@jdoupe jdoupe force-pushed the add-extra-labels branch from deef220 to 0290a9e Compare April 4, 2026 17:08
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
@jdoupe
Copy link
Copy Markdown
Contributor Author

jdoupe commented Apr 4, 2026

@frouioui - I wanted to mention that in addition to the steps outlined in #629 (comment)

that it appears that the WATCH_NAMESPACE variable has also been altered (by you ;P ) in the time since, and likely needs to be "watched" on any change, as well as the securityContext that @mattlord added in the recent past.

Don't know if either or both of those are appropriate to add to the source (deploy/deployment.yaml).

I'll also note that kustomize(?) looks like it may have changed a bunch of whitespace things, as well as some other mundane bits.

All in all, this looks relatively straightforward, so do let me know if something else needs a tweak.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add extraLabels option for backup pods

3 participants