Add extraLabels to both subcontroller and vbsc pods#735
Add extraLabels to both subcontroller and vbsc pods#735jdoupe wants to merge 4 commits intoplanetscale:mainfrom
Conversation
|
@jdoupe can you please create a quick issue that describes what problem you're trying to solve? And link it to the PR here. Thanks! |
c7ba815 to
ce2285c
Compare
|
Administrative note: (and you're probably already aware) the |
|
Bump @frouioui |
frouioui
left a comment
There was a problem hiding this comment.
Hi! The operator manifest and the vitess repository will need to be modified given this PR updates the CRDs. A guide on how to do this is available here:
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
|
@frouioui - I wanted to mention that in addition to the steps outlined in #629 (comment) that it appears that the WATCH_NAMESPACE variable has also been altered (by you ;P ) in the time since, and likely needs to be "watched" on any change, as well as the securityContext that @mattlord added in the recent past. Don't know if either or both of those are appropriate to add to the source (deploy/deployment.yaml). I'll also note that kustomize(?) looks like it may have changed a bunch of whitespace things, as well as some other mundane bits. All in all, this looks relatively straightforward, so do let me know if something else needs a tweak. Thanks! |
Fixes #736
By adding the following:
vitessbackupschedules.spec.extraLabels
vitessbackupstorages.spec.extraLabels
vitessclusters.spec.backup.extraLabels
For vtbackup(-init), the code has just been modified to pass along the existing extraLabels on the tabletPool.
@mattlord / @frouioui