[Fix] Reduce Sentry noise in browser_live environment#2011
Merged
Conversation
Skip emitting asset:op events when the realtime asset document has been unloaded. Prevents stale ops from propagating after unload() sets _loaded to false but before the listener is fully detached. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…G3DB) The missing child entity error is a non-fatal race condition during scene load. The user already sees a status bar error; downgrade from log.error (Sentry) to console.warn (local only) to reduce noise. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Server-side 400 "invalid characters" responses already show a status bar error to the user. Downgrade from log.error (Sentry) to console.warn (local only) to avoid unnecessary Sentry events. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The _connected flag can be true while the WebSocket is in CLOSING state, causing InvalidStateError on send(). Add a readyState check to guard against this race condition. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
WebGL context creation failure is an environmental limitation, not a code bug. Downgrade from log.error (Sentry) to console.error (local only). The user still sees the full-screen overlay explaining the issue. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Multiple event listeners (relay:connected, realtime:connected) can trigger joinRoom() for the same room before the server confirms the first join. Track pending join requests in a Set and skip duplicates to prevent "Client already joined room" server rejections. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Six low-hanging-fruit fixes for the top unresolved Sentry issues in the
browser_liveenvironment (~114 events/14d eliminated):RealtimeAsset._onOpwhen document is unloaded — prevents stale ops from emitting afterunload()log.error→console.warn— non-fatal race during scene load, user already sees status bar errorlog.error→console.warn— server 400 "invalid characters" already shown to user via status barsocket.readyState === WebSocket.OPENcheck in relaysend()— preventsInvalidStateErrorwhen socket is in CLOSING statelog.error→console.error— environmental limitation, not a code bug; overlay still shown to user_pendingRoomsSet in relay server — prevents duplicatejoinRoom()requests from racing event listenersChecks