Skip to content

Revert Android Asset Breaking Changes - #934

Merged
brocollie08 merged 8 commits into
mainfrom
revert-android-asset-consolidation
Sep 9, 2026
Merged

Revert Android Asset Breaking Changes#934
brocollie08 merged 8 commits into
mainfrom
revert-android-asset-consolidation

Conversation

@brocollie08

@brocollie08 brocollie08 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Revert Android asset API to pre-1.0 state

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs
📦 Published PR as canary version: 1.2.0--canary.934.42511

Try this version out locally by upgrading relevant packages to 1.2.0--canary.934.42511

@intuit-svc

intuit-svc commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

Comparison against baseline from main. ⚠️ = regression (>10% slower), ✅ = improvement (>5% faster)

core/player ⚠️

Benchmark Current Baseline Change
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.bar 807.65K ops/s 579.17K ops/s +39.4% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets.1.name 523.67K ops/s 505.87K ops/s +3.5%
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets.01.name 512.38K ops/s 472.78K ops/s +8.4% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets['01'].name 471.39K ops/s 442.84K ops/s +6.4% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets[01].name 514.06K ops/s 462.48K ops/s +11.2% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets[name = "frodo"].type 280.68K ops/s 278.95K ops/s +0.6%
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets["name" = "sprinkles"].type 225.83K ops/s 202.76K ops/s +11.4% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets["isDog" = false].type 255.03K ops/s 287.14K ops/s -11.2% ⚠️
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets["isDog" = true].type 261.06K ops/s 303.01K ops/s -13.8% ⚠️
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.bar 551.01K ops/s 564.36K ops/s -2.4%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets.1.name 341.20K ops/s 357.78K ops/s -4.6%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets.01.name 351.09K ops/s 372.88K ops/s -5.8%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets['01'].name 332.05K ops/s 333.35K ops/s -0.4%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets[01].name 368.65K ops/s 363.00K ops/s +1.6%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets[name = "frodo"].type 231.09K ops/s 232.07K ops/s -0.4%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets["name" = "sprinkles"].type 185.61K ops/s 172.37K ops/s +7.7% ✅
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets["isDog" = false].type 179.49K ops/s 163.38K ops/s +9.9% ✅
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets["isDog" = true].type 220.44K ops/s 228.78K ops/s -3.6%
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = 1 + 3 (sync) 439.83K ops/s 380.22K ops/s +15.7% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = 1 + 3 (async) 328.56K ops/s 264.10K ops/s +24.4% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: conditional(true, true, false) (sync) 476.99K ops/s 394.06K ops/s +21.0% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: conditional(true, true, false) (async) 384.46K ops/s 367.34K ops/s +4.7%
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional({{bar}} > 0, true, false) (sync) 160.04K ops/s 196.44K ops/s -18.5% ⚠️
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional({{bar}} > 0, true, false) (async) 187.72K ops/s 138.81K ops/s +35.2% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional(conditional(true = false, false, true), conditional(false = false, true, false), conditional(true = true, false, true)) (sync) 129.28K ops/s 137.60K ops/s -6.1%
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional(conditional(true = false, false, true), conditional(false = false, true, false), conditional(true = true, false, true)) (async) 126.60K ops/s 119.68K ops/s +5.8% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = await(asyncTestFunction(1)) (sync) N/A N/A N/A
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = await(asyncTestFunction(1)) (async) 243.14K ops/s 221.69K ops/s +9.7% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = asyncTestFunction(1) (sync) 244.54K ops/s 282.49K ops/s -13.4% ⚠️
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = asyncTestFunction(1) (async) 242.72K ops/s 241.94K ops/s +0.3%
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: asyncTestFunction(1) (sync) 745.65K ops/s 782.55K ops/s -4.7%
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: asyncTestFunction(1) (async) 609.85K ops/s 653.19K ops/s -6.6%
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional(!{{bar}} == false, await(asyncTestFunction(1)), false) (sync) 164.28K ops/s 182.03K ops/s -9.7%
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional(!{{bar}} == false, await(asyncTestFunction(1)), false) (async) 141.66K ops/s 166.04K ops/s -14.7% ⚠️
core/player/src/view/resolver/__tests__/index.bench.ts > resolver benchmarks > initial resolve 487.29 ops/s 601.89 ops/s -19.0% ⚠️
core/player/src/view/resolver/__tests__/index.bench.ts > resolver benchmarks > Resolving from cache 18.30K ops/s 17.77K ops/s +3.0%
core/player/src/view/resolver/__tests__/index.bench.ts > resolver benchmarks > data changes 1.96K ops/s 2.46K ops/s -20.3% ⚠️
core/player/src/view/resolver/__tests__/index.bench.ts > resolver benchmarks > data changes slow 410.95 ops/s 593.00 ops/s -30.7% ⚠️

plugins/async-node/core ⚠️

Benchmark Current Baseline Change
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 1 times 13.36K ops/s 13.26K ops/s +0.8%
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 5 times 14.23K ops/s 12.90K ops/s +10.3% ✅
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 10 times 10.94K ops/s 9.37K ops/s +16.8% ✅
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 50 times 3.54K ops/s 2.71K ops/s +30.7% ✅
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 100 times 1.85K ops/s 1.59K ops/s +15.8% ✅
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 1 times 3.99K ops/s 5.91K ops/s -32.4% ⚠️
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 5 times 5.93K ops/s 6.74K ops/s -12.0% ⚠️
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 10 times 4.81K ops/s 5.02K ops/s -4.2%
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 50 times 2.05K ops/s 2.25K ops/s -9.1%
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 100 times 1.61K ops/s 1.34K ops/s +20.2% ✅

react/player

Benchmark Current Baseline Change
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 1 ReactAssets 629.91 ops/s 590.60 ops/s +6.7% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 1 ReactAssets 1.07K ops/s 1.12K ops/s -4.2%
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 5 ReactAssets 620.83 ops/s 582.33 ops/s +6.6% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 5 ReactAssets 1.02K ops/s 990.82 ops/s +3.1%
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 10 ReactAssets 636.38 ops/s 597.49 ops/s +6.5% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 10 ReactAssets 869.34 ops/s 816.36 ops/s +6.5% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 50 ReactAssets 527.61 ops/s 487.11 ops/s +8.3% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 50 ReactAssets 278.05 ops/s 276.71 ops/s +0.5%
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 100 ReactAssets 432.64 ops/s 398.46 ops/s +8.6% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 100 ReactAssets 132.79 ops/s 113.24 ops/s +17.3% ✅

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Aug 18, 2026
@intuit-svc

intuit-svc commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Build Preview

Your PR was deployed by CircleCI #42511 on Tue, 01 Sep 2026 18:12:49 GMT with this version:

1.2.0--canary.934.42511

📖 Docs (View site)

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (df19d9f) to head (9e4163a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #934   +/-   ##
===========================
===========================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brocollie08 brocollie08 added the minor Increment the minor version when merged label Aug 28, 2026
@brocollie08

Copy link
Copy Markdown
Contributor Author

/canary

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Sep 1, 2026
@brocollie08
brocollie08 marked this pull request as ready for review September 3, 2026 14:54
@brocollie08
brocollie08 requested a review from a team as a code owner September 3, 2026 14:54
@brocollie08
brocollie08 merged commit 54f0d0f into main Sep 9, 2026
19 checks passed
@brocollie08
brocollie08 deleted the revert-android-asset-consolidation branch September 9, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants