BUGFIX KernelVersion compare __lt__#150
Merged
ukablan-wpc merged 1 commit intoJun 18, 2026
Merged
Conversation
SandakovMM
reviewed
Jun 18, 2026
ukablan-wpc
force-pushed
the
bugfix-ukablan-kernel_version_compare_lt-PAUX-7106
branch
from
f82a490 to
c496311
Compare
ukablan-wpc
commented
Jun 18, 2026
Comment on lines
+119
to
+121
| vers = ["4.18.0-553.134.1.el8_10.x86_64", "3.10.0-1160.119.1.el7.x86_64", "3.10.0-1160.80.1.el7.x86_64"] | ||
| maxkernel = max([version.KernelVersion(v) for v in vers]) | ||
| self.assertEqual(maxkernel, version.KernelVersion("4.18.0-553.134.1.el8_10.x86_64")) |
Contributor
Author
There was a problem hiding this comment.
Weird enough this doesn't fail:
k1 = version.KernelVersion("3.10.0-1160.80.1.el7.x86_64")
k2 = version.KernelVersion("3.10.0-1160.119.1.el7.x86_64")
k3 = version.KernelVersion("4.18.0-553.134.1.el8_10.x86_64")
self.assertLess(k2, k3)
self.assertLess(k1, k3)
self.assertLess(k1, k2)
Contributor
Author
There was a problem hiding this comment.
Found minimal test with >=
ukablan-wpc
force-pushed
the
bugfix-ukablan-kernel_version_compare_lt-PAUX-7106
branch
from
c496311 to
4b1c226
Compare
ukablan-wpc
force-pushed
the
bugfix-ukablan-kernel_version_compare_lt-PAUX-7106
branch
from
4b1c226 to
d2f004d
Compare
SandakovMM
approved these changes
Jun 18, 2026
ukablan-wpc
deleted the
bugfix-ukablan-kernel_version_compare_lt-PAUX-7106
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.