Fix/compliance response mapping#263
Merged
koushiksk-plivo (koushiksk-plivo) merged 5 commits intoApr 17, 2026
Merged
Conversation
The API returns GET responses wrapped under a 'compliance' key and list responses under a 'compliances' key, but the SDK expected flat responses and 'objects' respectively. Override get() to extract the compliance wrapper and list() to remap 'compliances' to 'objects' for base class compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The PATCH update response wraps data under a 'compliance' key, but update() was passing the raw response to parse_and_set, causing fields like alias, status, and compliance_id to not be set on the resource. Apply the same unwrapping logic already used by get(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…sistent - Update GET mock to wrap response under 'compliance' key - Update LIST mock to use 'compliances' key instead of 'objects' - Update UPDATE mock to wrap response under 'compliance' key - Update test assertions to verify unwrapping/remapping logic - Use consistent || fallback pattern in update() matching get() - Add comment explaining message field injection into resource state Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
avinashp-plivo
approved these changes
Apr 17, 2026
koushiksk-plivo (koushiksk-plivo)
merged commit 1302f2a
into
master
8 of 11 checks passed
koushiksk-plivo (koushiksk-plivo)
deleted the
fix/compliance-response-mapping
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.