Repository navigation
Conversation
Phase 1 of #269. Also add the missing stories for Table, GridList (with drag and drop), Dialog and ComboBox.
* feat/react-aria-1.22: Drop the unused React imports in @plone/controlpanels Ship @plone/controlpanels as source, like the other add-ons
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of #269. Stacked on #273 (React Aria 1.22).
Adds the Quanta controls that the content types control panel needs and that Quanta didn't have yet. Like the rest of Quanta, they are thin, Tailwind-styled wrappers around React Aria Components and keep its API.
New components
Switch: built on React Aria'sSwitchFieldandSwitchButtonfrom 1.18, not on theSwitchthat 1.18 deprecated. It takes an optionaldescription(linked to the control througharia-describedby) and anerrorMessage, which is what settings rows like "Globally addable / Editors can add events in any folder…" need.ToggleButtonandToggleButtonGroup: a toggle button and a segmented control. WithselectionMode="single"the group works like a compact radio group, e.g. the type list filters "All · Custom · Not addable". It supports multiple selection and vertical orientation.ProgressBar: with a label and value text, determinate or indeterminate (pulsing, still with reduced motion). It will show the progress of a workflow change.Drawer: aModalthat slides in from the right (or left) over a backdrop, for editing an item next to its list, e.g. the field editor. It can be dismissed by default.New stories for existing components
Table(selection and sorting, empty state),GridList(selection, plus drag and drop reordering withuseDragAndDrop),Dialog(confirmation in a modal, dialog in a popover) andComboBox.Left out on purpose
AccordionItem,AccordionItemTriggerandAccordionPanelalready wrap React Aria'sDisclosureand work outside anAccordion, so a separate component would duplicate them.@plone/layout.Drawer.Checks
pnpm --filter @plone/quanta test --run: 11 tests pass, including axe checks for each new component.pnpm --filter @plone/quanta lint,build,check:exportsandbuild-storybookpass.