feat(client): Add imports and new fragments for stack and service models#3339
feat(client): Add imports and new fragments for stack and service models#3339maciaszczykm merged 3 commits intomasterfrom
Conversation
Greptile SummaryThis PR extends the Go GraphQL client with new fragments and fields needed by the plural-cli:
Confidence Score: 3/5
|
| Filename | Overview |
|---|---|
| go/client/graph/stack.graphql | Adds the new InfrastructureStackTinyFragment (id + name) used by the service imports field. No issues. |
| go/client/graph/models.graphql | Extends ServiceDeploymentExtended with the imports field and BaseClusterFragment with distro and tags. All referenced fragments already exist. No issues. |
| go/client/client.go | Auto-generated file with new structs and getters for InfrastructureStackTinyFragment, ServiceDeploymentExtended_Imports, ClusterTags additions to BaseClusterFragment, and per-operation copies of the Imports type. All changes follow existing patterns. |
| go/client/models_gen.go | Removes NexusSettings, NexusSettingsAttributes from the generated client models and removes Nexus from AiSettings/AiSettingsAttributes. Changes are consistent with a schema removal. |
| go/controller/api/v1alpha1/deploymentsettings_types.go | Comments out the Nexus attribute mapping in Attributes(), but leaves the Nexus field on AISettings and the full NexusSettings type intact, meaning the CRD still accepts Nexus config that is now silently ignored. |
| go/client/generated/persisted-queries/queries.json | Auto-generated persisted query hashes updated to reflect the new fragments. No issues. |
Comments Outside Diff (1)
-
go/controller/api/v1alpha1/deploymentsettings_types.go, line 718-731 (link)Commented-out code leaves dead
Nexusfield silently ignoredThe
NexusSettingsAttributestype has been removed frommodels_gen.go, so the code that mapsin.Nexus→attr.Nexuswas commented out rather than deleted. However, theNexusfield still exists on theAISettingsCRD struct (line 468) and theNexusSettingstype remains fully defined (lines 983–1018).This means any cluster operator who has
nexus:configured in theirDeploymentSettingsCRD will now silently have that configuration ignored — no error is returned, no warning is logged, and the setting is never propagated to the API. This is a quiet regression for existing users.Consider one of:
- Remove the
Nexusfield andNexusSettingstype entirely (breaking, requires CRD version bump) - Keep the field but return an explicit error (or at least a warning log) when
in.Nexus != nil, so operators are informed the setting is no longer effective
- Remove the
Last reviewed commit: "comment out Nexus to..."
Needed for pluralsh/plural-cli#714.