Repository navigation
Added minimal permissions for 'spo folder sharinglink' commands. Closes #7275 - #7449
Merged
Merged
Conversation
Contributor
|
Thanks, we'll review it soon! |
Adam-it
requested changes
Jul 19, 2026
Adam-it
left a comment
Adam-it
left a comment
Member
There was a problem hiding this comment.
@SmitaNachan awesome work so far but there are a few things that were missed.
May I kindly ask you to give it an another go before we make this a perfect merge 💪
You Rock 🤩
Adam-it
marked this pull request as draft
July 19, 2026 20:16
SmitaNachan
marked this pull request as ready for review
July 20, 2026 15:27
Adam-it
requested changes
Sep 2, 2026
Adam-it
left a comment
Adam-it
left a comment
Member
There was a problem hiding this comment.
@SmitaNachan Awesome job. From what I checked all of those commands use helper chain commands that do the following
spo.getSiteIdByMSGraph() | GET /v1.0/sites/{host}:{path}?$select=id
drive.getDriveByUrl() | GET /v1.0/sites/{siteId}/drives?$select=webUrl,id
drive.getDriveItemId() | GET /v1.0/drives/{driveId}/root:{path}?$select=id
for this I think we need to mention Sites.Read.All for MS Graph added as well
Adam-it
marked this pull request as draft
September 2, 2026 21:47
SmitaNachan
marked this pull request as ready for review
October 5, 2026 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added minimal permissions for
spo folder sharinglinkcommands. Closes #7275