Skip to content

fix(Foundation): strToInt rejects a minus sign after a plus sign #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleks-f merged 1 commit into from
Oct 28, 2026
Merged

fix(Foundation): strToInt rejects a minus sign after a plus sign #5598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Foundation/include/Poco/NumericString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ template <typename I>
const char* start = begin;
if (*start == '+') ++start;
if (start >= end) return false; // reject bare sign without digits
if (start != begin && *start == '-') return false; // reject a sign after '+'

// Try std::from_chars -- handles sign, overflow, and all bases.
const auto [ptr, ec] = std::from_chars(start, end, outResult, base);
Expand Down
6 changes: 6 additions & 0 deletions Foundation/testsuite/src/NumberParserTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,12 @@ void NumberParserTest::testParseError()
failmsg("must throw SyntaxException");
} catch (SyntaxException&) { }

try
{
(void) NumberParser::parse("+-123");
failmsg("must throw SyntaxException");
} catch (SyntaxException&) { }

try
{
(void) NumberParser::parseUnsigned("-123");
Expand Down
2 changes: 2 additions & 0 deletions Foundation/testsuite/src/StringTest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ class StringTest: public CppUnit::TestCase

assertFalse (Poco::strToInt("1,000", result, 0x10));
assertFalse (Poco::strToInt("ABCDEFG", result, 0x10));
assertFalse (Poco::strToInt("+-123", result, 10));
assertFalse (Poco::strToInt("+-123", result, 0x10));
}

template <typename Larger, typename Smaller>
Expand Down
Loading