Skip to content

docs: refresh recent behavior notes#262

Open
poe-code-agent[bot] wants to merge 2 commits intomainfrom
agent/update-documentation
Open

docs: refresh recent behavior notes#262
poe-code-agent[bot] wants to merge 2 commits intomainfrom
agent/update-documentation

Conversation

@poe-code-agent
Copy link
Copy Markdown
Contributor

@poe-code-agent poe-code-agent Bot commented Apr 29, 2026

Summary

  • Document that Toolcraft group help shows child command parameter tokens inline.
  • Document provider preferred-login resolution for OAuth-backed API-key login.
  • Document Goose spawn env overrides for file-backed credentials.

Verification

  • Reviewed commits on origin/main from the last 24 hours.
  • Verified documentation claims against packages/providers/src/*, packages/agent-spawn/src/configs/goose.ts, and the existing Toolcraft README change.
  • git grep -n "preferredLogin\|GOOSE_DISABLE_KEYRING" packages/providers packages/agent-spawn src/providers

@poe-code-agent poe-code-agent Bot force-pushed the agent/update-documentation branch from 1846751 to 1717f39 Compare April 29, 2026 00:33
Copy link
Copy Markdown
Contributor Author

@poe-code-agent poe-code-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor Author

@poe-code-agent poe-code-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poe-code-agent poe-code-agent Bot force-pushed the agent/update-documentation branch from 1717f39 to 021fc50 Compare May 1, 2026 00:31
@poe-code-agent poe-code-agent Bot changed the title docs: document toolcraft group help parameters docs: refresh recent behavior notes May 1, 2026
Copy link
Copy Markdown
Contributor Author

@poe-code-agent poe-code-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes: one Toolcraft CLI help note contradicts current output.


**Tree**: the `root` group is a `defineGroup` whose children are commands and sub-groups. Any depth. CLI flags, MCP tool names, and SDK methods are derived from the path.

**CLI help**: group help lists visible child commands with their parameter tokens inline. Required options appear as `--name <type>`, optional options and defaults appear in brackets like `[--limit <number>]`, and positional parameters stay unbracketed even when the underlying schema field is optional. Command-specific `--help` still shows the detailed parameter table.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optional positional wording looks inverted. formatCommandParameterTokens() still goes through formatPositionalToken(), so optional/default positionals render with brackets like [agent], not unbracketed.

Suggested change
**CLI help**: group help lists visible child commands with their parameter tokens inline. Required options appear as `--name <type>`, optional options and defaults appear in brackets like `[--limit <number>]`, and positional parameters stay unbracketed even when the underlying schema field is optional. Command-specific `--help` still shows the detailed parameter table.
**CLI help**: group help lists visible child commands with their parameter tokens inline. Required options appear as `--name <type>`, optional options and defaults appear in brackets like `[--limit <number>]`, and positional parameters render as positional tokens like `<name>` or `[name]` depending on whether they are required. Command-specific `--help` still shows the detailed parameter table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants