fix: return actual API result from delete_branch#117
Open
HelenGreul wants to merge 1 commit into
Open
Conversation
`delete_branch` unconditionally returned `True` regardless of the API response. Callers in `cli.py` check this value to display success or failure messages, so a failed deletion was always reported as successful. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Ruari-Phipps
approved these changes
Apr 29, 2026
Contributor
|
This pull request has been automatically marked as stale because it has not had any activity in 30 days. It will be closed in 7 days if no further activity occurs. If this is still in progress, please push an update or leave a comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Project.delete_branch()unconditionally returnstrueregardless of the API responsebranch_deletesingle and multi-select paths) check this value to display success/failure - a failed deletion was always reported as successfulreturn True→return success