Fix portainer-agent chart ServiceAccount naming [PLA-709]#18
Open
Fix portainer-agent chart ServiceAccount naming [PLA-709]#18
Conversation
…count [PLA-709] The unified portainer-agent chart was using the fullname helper for ServiceAccount naming, producing names like 'portainer-agent' instead of 'portainer-sa-clusteradmin'. This caused kubectl-shell to fail on edge agent clusters where no server chart is present to create the expected SA. - Default serviceAccount.name to portainer-sa-clusteradmin in values.yaml - Use serviceAccountName helper in serviceaccount.yaml, rbac.yaml, deployment.yaml - Name ClusterRoleBinding as portainer-sa-clusteradmin-crb - Add container port 80 for edge/edge-async modes (matching official manifest) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yajith
force-pushed
the
fix/pla-709/agent-chart-sa
branch
from
c8fb317 to
5e73fd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
portainer-agenthelm chart was using thefullnamehelper for ServiceAccount/ClusterRoleBinding naming, producing names likeportainer-agentinstead ofportainer-sa-clusteradminagent,edge, andedge-asynccharts all defaulted toportainer-sa-clusteradmin— the unified chart missed thisChanges
serviceAccount.nametoportainer-sa-clusteradmininvalues.yamlserviceAccountNamehelper (already existed in_helpers.tpl) inserviceaccount.yaml,rbac.yaml, anddeployment.yamlportainer-sa-clusteradmin-crb(matchesportainer-crb-cleanup pattern)Companion PR
Test plan
helm templatedry-run for agent, edge, and edge-async modes confirms SA namedportainer-sa-clusteradminhelm templatewithserviceAccount.create=falseproduces no SA/CRB but deployment still referencesportainer-sa-clusteradmin