feat: staging setup for extensions #296
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshyam-k
commented
Nov 14, 2025
| - name: Get manifest extension version | ||
| run: | | ||
| MANIFEST_VERSION=$(semver -c $(jq -c -r '.extension.version' < ./extensions/${{ inputs.extension-name }}/manifest.json)) | ||
| MANIFEST_VERSION=$(semver -c -p $(jq -c -r '.extension.version' < ./extensions/${{ inputs.extension-name }}/manifest.json)) |
Author
There was a problem hiding this comment.
the -p flag makes it so we always include prerelease versions in range matching.
joshyam-k
commented
Nov 14, 2025
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: release-${{ inputs.extension-name }}.json | ||
| name: release-${{ inputs.extension-name }}${{ env.PRERELEASE == 'true' && '-prerelease' || '' }}.json |
Author
There was a problem hiding this comment.
artifact gets a '-prerelease' suffix to make for easier management in extensions.yml
joshyam-k
commented
Nov 14, 2025
|
|
||
| # don't add prerelease files to extensions.json on main | ||
| # TODO: verify this does what we want | ||
| - name: Remove prerelease files |
Author
There was a problem hiding this comment.
We need to make sure we don't fetch pre-release versions here.
joshyam-k
commented
Nov 14, 2025
| if: ${{ always() && needs.fetch-prerelease-releases.result == 'success' && needs.fetch-prerelease-releases.outputs.releases != '[]' }} | ||
| env: | ||
| RELEASES: ${{ needs.fetch-prerelease-releases.outputs.releases }} | ||
| EXTENSION_LIST_FILE: extensions-prerelease.json |
Author
There was a problem hiding this comment.
writing to a separate file called extensions-prerelease.json
Author
|
@dotNomad zero rush on this, but if you want to take an early look at this to make sure I'm not driving things in the complete wrong direction that would be helpful! Still a couple pieces to do, but most of the basic structure is there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT
note: claude wrote the initial version of tests for extension-list, but I went back in and did a ton of editing and removing.
TODO: