Skip to content

Conversation

@Meghansaha
Copy link
Contributor

@Meghansaha Meghansaha commented Nov 11, 2025

Summary

This PR addresses #285 by adding:

  • print_database_tables()
  • _handle_connection_errors()
  • updates to connect_to_table()

The new _handle_connection_errors() function pulls out the connection checks that were previously built into connect_to_table() and makes them reusable. It’s also been expanded to handle database-level checks, not just tables. Both print_database_tables() and connect_to_table() now rely on it for consistent error handling.

Test Coverage

Added full test coverage for all new and updated connection utilities:

  • connect_to_table() — 1 test updated, plus 5 new tests for success cases, missing dependencies, invalid tables, and error handling
  • print_database_tables() — 6 new tests covering table listing, dependency checks, and memtable filtering
  • _handle_connection_errors() — covered indirectly through connection error scenarios in the tests above

Related GitHub Issues and PRs

Checklist

@Meghansaha Meghansaha changed the title Add print available tables Add print_database_tables() Nov 11, 2025
@Meghansaha
Copy link
Contributor Author

@rich-iannone Tried to make this as complete as possible! Getting full test coverage took some work (with a little help from Copilot 😅), but I’m showing 100% coverage locally for the changes in this PR. I did try to pull in the .github workflow ci/test yml from main to see if the 3.14 build check would magically pass for me, but it did not lol. Let me know if you’d like to discuss anything further.

@Meghansaha Meghansaha marked this pull request as ready for review November 12, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant