fix: require ws auth token for remote access#23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
AGENT_TUI_API_TOKENintoWsConfigand carry it into runtime state (WsState) incli/crates/agent-tui-app/src/app/daemon/ws_server.rs.ws_handler, acceptingAuthorization: Bearer <token>or?token=/?access_token=query parameters, and return401with an RPC error payload for unauthorized requests.AGENT_TUI_WS_ALLOW_REMOTE=1requiresAGENT_TUI_API_TOKENto prevent accidental unauthenticated remote exposure.Testing
cd cli && cargo fmt(succeeded).cd cli && cargo test -p agent-tui-app ws_config_reads_ws_env(passed).cd cli && cargo test -p agent-tui-app bind_listener_requires_token_when_remote_is_allowed(passed).Codex Task