feat(openai): Reasoning translation for responses to chat completions - #1014
Open
s-akhtar-baig wants to merge 8 commits into
Open
feat(openai): Reasoning translation for responses to chat completions#1014s-akhtar-baig wants to merge 8 commits into
s-akhtar-baig wants to merge 8 commits into
Conversation
|
Unsigned commits: 64fee79. Please sign your commits. |
Signed-off-by: Shabana Baig <43451943+s-akhtar-baig@users.noreply.github.com>
Signed-off-by: Shabana Baig <43451943+s-akhtar-baig@users.noreply.github.com>
Signed-off-by: Shabana Baig <43451943+s-akhtar-baig@users.noreply.github.com>
Signed-off-by: Shabana Baig <43451943+s-akhtar-baig@users.noreply.github.com>
s-akhtar-baig
force-pushed
the
reasoning_translation
branch
from
September 8, 2026 16:32
eac84ad to
cd8bde4
Compare
s-akhtar-baig
force-pushed
the
reasoning_translation
branch
from
September 8, 2026 17:51
c8f8865 to
ae91290
Compare
Signed-off-by: Shabana Baig <43451943+s-akhtar-baig@users.noreply.github.com>
…hat_completions filter Signed-off-by: Shabana Baig <43451943+s-akhtar-baig@users.noreply.github.com>
s-akhtar-baig
force-pushed
the
reasoning_translation
branch
from
September 8, 2026 18:35
ae91290 to
7aedf8f
Compare
Signed-off-by: Shabana Baig <43451943+s-akhtar-baig@users.noreply.github.com>
praxis-bot
reviewed
Sep 8, 2026
praxis-bot
left a comment
praxis-bot
left a comment
There was a problem hiding this comment.
praxis-bot review: feat(openai): Reasoning translation for responses to chat completions
Clean feature addition. The reasoning dialect abstraction is well-structured, validation is thorough, and test coverage is strong across request validation, response extraction, dialect fallback, size limits, and the end-to-end integration path. The resolve_vllm_reasoning field-priority logic correctly handles all combinations of current/deprecated/null/empty/malformed field states.
One medium finding on the response path.
| Severity | Count |
|---|---|
| Medium | 1 |
Signed-off-by: Shabana Baig <43451943+s-akhtar-baig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable reasoning dialect to the responses_to_chat_completions filter so that raw chain-of-thought returned by a Chat Completions backend is surfaced as a first-class Responses reasoning output item. The first dialect is vllm; the default (none) preserves existing behavior.
A reasoning summary request is currently rejected and is out of scope for #31.
Related issue
Implements part one for #31. Streaming reasoning translation is deferred to #36 and will be added as a follow-up PR once all the bug fixes land in main.
Validation
make lintChecklist
Signed-off-bytrailer.Breaking changes