docs(proposals): complete #784 spike with How? and closure criteria - #14
Conversation
fc06cc8 to
e3f96f1
Compare
praxis-bot
left a comment
praxis-bot
left a comment
There was a problem hiding this comment.
praxis-bot review: proposals/00784_structured-security-audit-log-format.md
Thorough spike completion. The format comparison, schema draft, sink architecture, decisions, and How? sections are well-structured and answer the original open questions clearly. Four items need resolution before this is ready to merge.
Findings: 0 critical, 0 large, 4 medium
e3f96f1 to
15182e0
Compare
praxis-bot
left a comment
praxis-bot
left a comment
There was a problem hiding this comment.
praxis-bot re-review: proposals/00784_structured-security-audit-log-format.md
All four findings from the previous review have been addressed. One new item surfaced on the updated How? section.
Findings: 0 critical, 0 large, 1 medium
Add format comparison, Praxis Audit Record v1 schema, sink architecture, Decisions, and implementation How?. Spike completion section documents that merging closes praxis-proxy/praxis#784. Signed-off-by: Hen Schwartz <hschwart@redhat.com>
15182e0 to
67e487e
Compare
praxis-bot
left a comment
praxis-bot
left a comment
There was a problem hiding this comment.
PR Review (re-review)
Previous inline comment on proposals/00784_structured-security-audit-log-format.md (integration test assertion marked optional) resolved by 67e487e. The How? section now explicitly marks the integration test audit-record verification as required and states "HTTP 403 alone is insufficient."
No new actionable findings. The added format comparison, schema draft, sink architecture, Decisions, and How? sections are thorough and well-structured.
shaneutt
left a comment
shaneutt
left a comment
There was a problem hiding this comment.
Taking as proposed and we'll continue to iterate and discuss. Thank you @henschwartz
| @@ -7,26 +7,19 @@ repos: | |||
| authors: | |||
| - henschwartz | |||
| graduation_criteria: | |||
There was a problem hiding this comment.
Needs status=proposed as we're not ready to move forward with implementation yet
| graduation_criteria: | |
| status: proposed | |
| graduation_criteria: |
3 participants
Summary
Test plan