build(deps): bump base64 from 0.22.1 to 0.23.1 - #62
Conversation
|
Holding this open rather than merging or closing it.
Merging now would split that. This becomes a clean merge as soon as |
praxis-bot
left a comment
There was a problem hiding this comment.
praxis-bot review — base64 0.22.1 → 0.23.1
No findings.
Checked:
- All three consumers (
delegator-oauth,elicitation-ciba,identity-jwt) use only stable API surface:Enginetrait import,general_purpose::STANDARD/URL_SAFE_NO_PADwith.encode()/.decode(). All remain in 0.23. DecodeError::InvalidLastSymbolgained a field, but no consumer pattern-matches on it (all uselet Ok(..) = .. else).- MSRV 1.96 exceeds base64 0.23’s requirement of 1.71.
- CI: 7/7 checks pass.
- The default-on
simd-unsafefeature adds SIMD acceleration inside the dependency; it does not affectdeny(unsafe_code)in the policy crates themselves.
Clean bump. No action required.
Bumps [base64](https://github.com/marshallpierce/rust-base64) from 0.22.1 to 0.23.1. - [Changelog](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md) - [Commits](marshallpierce/rust-base64@v0.22.1...v0.23.1) --- updated-dependencies: - dependency-name: base64 dependency-version: 0.23.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
185beea to
6a471b6
Compare
praxis-bot
left a comment
There was a problem hiding this comment.
PR Review
Summary: Rebased since last review. No functional diff change. One stale comment found.
| Severity | Count |
|---|---|
| Critical | 0 |
| Large | 0 |
| Medium | 1 |
| # of the middle JWT segment). Pinned to 0.22 to match what | ||
| # jsonwebtoken pulls — Cargo dedups to a single version. | ||
| base64 = "0.22" | ||
| base64 = "0.23" |
There was a problem hiding this comment.
[Medium] This comment still says "Pinned to 0.22 to match what jsonwebtoken pulls" but the version is now 0.23. The comment should be updated to reflect the new version, or rephrased to drop the specific version reference since base64 and jsonwebtoken may diverge independently.
Bumps base64 from 0.22.1 to 0.23.1.
Changelog
Sourced from base64's changelog.
Commits
069bf70v0.23.16ab1fb0Merge pull request #310 from musicinmybrain/test-on-non-simd-arches7cffce6Fix testing on architectures without unsafe SIMD supporte34f9a0Merge pull request #308 from atouchet/come9240c9Remove outdated comment9e9220av0.23.0870326eMerge pull request #306 from marshallpierce/mp/trailing-bits-docsfbec5f1Document no trailing trailing bits0a23549Merge pull request #305 from marshallpierce/mp/edition-2021f10b7e2Update deps & edition