Tests: Support GPP USNat v2 #3766

osulzhenko · 2025-02-18T21:27:08Z

🔧 Type of changes

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

verify email contact works
NO fully dynamic hostnames
geographic host parameters are NOT required
direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

…support-gpp-usnat-v2 # Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/GppCookieSyncSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy # src/test/groovy/org/prebid/server/functional/util/privacy/gpp/GppConsent.groovy # src/test/groovy/org/prebid/server/functional/util/privacy/gpp/UsUtV1Consent.groovy # src/test/groovy/org/prebid/server/functional/util/privacy/gpp/UsVaV1Consent.groovy # src/test/groovy/org/prebid/server/functional/util/privacy/gpp/v1/UsCaV1Consent.groovy # src/test/groovy/org/prebid/server/functional/util/privacy/gpp/v1/UsCoV1Consent.groovy # src/test/groovy/org/prebid/server/functional/util/privacy/gpp/v1/UsCtV1Consent.groovy # src/test/groovy/org/prebid/server/functional/util/privacy/gpp/v1/UsNatV1Consent.groovy

marki1an · 2025-11-25T13:19:54Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy

+                        .setMspaServiceProviderMode(MspaMode.YES)
+                        .setMspaServiceProviderMode(MspaMode.NO)


Dublication

marki1an · 2025-11-25T13:24:04Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy

+        def cookieSyncRequest = CookieSyncRequest.defaultCookieSyncRequest.tap {
+            it.gppSid = US_NAT_V1.value
+            it.account = accountId
+            it.gpp = 'DBABLA~CAAAAAAAAASA.QA' // new UsNatV2Consent.Builder().setKnownChildSensitiveDataConsents(new UsNationalV2ChildSensitiveData(childFrom16to17: DataActivity.NO_CONSENT))


Use UsNatV2Consent instead of string

marki1an · 2025-11-26T00:28:06Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy

        ]
    }

+    def "PBS cookie sync call when privacy module contain some part of of disallow logic US nat v2 validation should exclude bidders URLs"() {


Weird naming

marki1an · 2025-11-26T00:28:31Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy

        ]
    }

+    def "PBS cookie sync call when privacy module contain some part of of disallow logic US nat v2 validation should exclude bidders URLs"() {


Also add negative scenario

marki1an · 2025-11-26T00:32:46Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitEidsActivitiesSpec.groovy

+                        .setMspaServiceProviderMode(MspaMode.YES)
+                        .setMspaServiceProviderMode(MspaMode.NO)


marki1an · 2025-11-26T00:34:59Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy

+        and: "Generic bidder request should have data in EIDS fields"
+        assert bidderRequest.user.eids == bidRequest.user.eids
+        where:
+        disallowGppLogic << [


Add empty line

marki1an · 2025-11-26T00:35:38Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy

        ]
    }

+    def "PBS auction call when privacy module contain some part of disallow raw logic US nat v2 validation should remove UFPD fields in request"() {


Same weird naming

What mean "some part"?

marki1an · 2025-11-26T00:42:34Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy

+                'DBABLA~CAAAqqiqqgCA.QA',   //SensitiveDataProcessing[1-7,9-16]=2
+                'DBABLA~CAAAVUAERACA.QA',   //SensitiveDataProcessing[1-5,11,13,15]=1
+                'DBABLA~CAAAABRREQCA.QA',   //SensitiveDataProcessing[6,7,9,10,12,14,16]=1
+                'DBABLA~CAAAACiiIgCA.QA'   //SensitiveDataProcessing[6,7,9,10,12,14,16]=2


Why not obj?

marki1an · 2025-11-26T09:36:51Z

src/test/groovy/org/prebid/server/functional/model/privacy/gpp/DataActivity.groovy

+
+import com.fasterxml.jackson.annotation.JsonValue
+
+enum DataActivity {


Don't see zero value in define doc

KnownChildSensitiveDataConsents, PersonalDataConsents, SensitiveDataProcessing: 1 - No Consent 2 - Consent

@marki1an https://github.com/InteractiveAdvertisingBureau/Global-Privacy-Platform/blob/main/Sections/US-National/IAB%20Privacy%E2%80%99s%20Multi-State%20Privacy%20Agreement%20(MSPA)%20US%20National%20Technical%20Specification.md#:~:text=0%20Not%20Applicable.%20The%20Business%20does%20not%20have%20actual%20knowledge%20that%20it%20Processes%20Personal%20Data%20or%20Sensitive%20Data%20of%20a%20Consumer%20who%20is%20a%20known%20child.

marki1an · 2025-11-26T09:41:08Z

src/test/groovy/org/prebid/server/functional/model/privacy/gpp/Notice.groovy

+    YES(1),
+    NO(2)


Raname to PROVIDED(1), NOT_PROVIDED(2) correspoding to doc.

SaleOptOutNotice, SharingNotice, TargetedAdvertisingOptOutNotice, SensitiveDataProcessingOptOutNotice, SensitiveDataLimitUseNotice: 0 - Not Applicable 1 - Notice was provided 2 - Notice was not provided

marki1an · 2025-11-26T09:43:33Z

...roovy/org/prebid/server/functional/model/privacy/gpp/UsCaliforniaV1ChildSensitiveData.groovy

+
+class UsCaliforniaV1ChildSensitiveData {
+
+    DataActivity childBlow13


Minor: renama please to childUnder13

marki1an · 2025-11-26T09:48:55Z

src/test/groovy/org/prebid/server/functional/model/privacy/gpp/UsColoradoV1SensitiveData.groovy

+    static UsColoradoV1SensitiveData generateRandomSensitiveData() {
+        new UsColoradoV1SensitiveData().tap {
+            racialEthnicOrigin = PBSUtils.getRandomEnum(DataActivity)
+            religiousBeliefs = PBSUtils.getRandomEnum(DataActivity)
+            healthInfo = PBSUtils.getRandomEnum(DataActivity)
+            orientation = PBSUtils.getRandomEnum(DataActivity)
+            citizenshipStatus = PBSUtils.getRandomEnum(DataActivity)
+            geneticId = PBSUtils.getRandomEnum(DataActivity)
+            biometricId = PBSUtils.getRandomEnum(DataActivity)
+        }
+    }
+
+    static UsColoradoV1SensitiveData fromList(List<DataActivity> data) {
+        if (data.size() != 7) {
+            throw new IllegalArgumentException("Invalid data size. Expected 7 values.")
+        }
+        new UsColoradoV1SensitiveData().tap {
+            racialEthnicOrigin = data[0]
+            religiousBeliefs = data[1]
+            healthInfo = data[2]
+            orientation = data[3]
+            citizenshipStatus = data[4]
+            geneticId = data[5]
+            biometricId = data[6]
+        }
+    }


Each class contains code that isn’t used, so the question is: do we need it?

marki1an · 2025-11-26T09:58:08Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppFetchBidActivitiesSpec.groovy

        new UsCtV1Consent.Builder().build()  | US_CT_V1
    }

+    def "PBS auction call when request have disallow logic US nat v2 validation should call bid adapter"() {


Weird naming — I literally can’t understand what this test is doing.

marki1an · 2025-11-27T18:36:19Z

.../groovy/org/prebid/server/functional/model/privacy/gpp/UsColoradoV1ChildSensitiveData.groovy

+    GppDataActivity childSensitive
+
+    static UsColoradoV1ChildSensitiveData getDefault(GppDataActivity childSensitive = GppDataActivity.NOT_APPLICABLE) {
+


marki1an · 2025-11-27T18:39:37Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy

+                new UsNatV2Consent.Builder()
+                        .setSharingOptOut(OptOut.DID_NOT_OPT_OUT)
+                        .build(),
+                new UsNatV2Consent.Builder()
+                        .setSharingOptOut(OptOut.DID_NOT_OPT_OUT)
+                        .build(),


Duplication logic

marki1an · 2025-11-27T18:41:51Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitEidsActivitiesSpec.groovy

+                new UsNatV2Consent.Builder()
+                        .setSharingOptOut(OptOut.DID_NOT_OPT_OUT)
+                        .build(),
+                new UsNatV2Consent.Builder()
+                        .setSharingOptOut(OptOut.DID_NOT_OPT_OUT)
+                        .build()


marki1an · 2025-11-27T18:48:11Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy

+        assert bidderRequest.user.eids == bidRequest.user.eids
+
+        where:
+        usNationalV2SensitiveData << [


Please check on unique values)

marki1an · 2025-11-28T10:45:54Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy

+                new UsNatV2Consent.Builder()
+                        .setSaleOptOut(OptOut.DID_NOT_OPT_OUT)
+                        .build(),


Here also duplication :)

osulzhenko added 2 commits February 18, 2025 10:22

wip

8d50bae

Add functional tests for GPP USNat v2

a1e5e05

osulzhenko added tests Functional or other tests blocked labels Feb 18, 2025

osulzhenko requested a review from marki1an February 18, 2025 21:27

osulzhenko self-assigned this Feb 18, 2025

osulzhenko removed the blocked label Nov 21, 2025

Fix conflicts

c4a5902

osulzhenko force-pushed the functional-tests/support-gpp-usnat-v2 branch from 623fee2 to c4a5902 Compare November 21, 2025 12:30

marki1an requested changes Nov 26, 2025

View reviewed changes

update after review

8c44524

osulzhenko requested a review from marki1an November 27, 2025 11:08

marki1an requested changes Nov 27, 2025

View reviewed changes

remove duplicates

638caa5

osulzhenko requested a review from marki1an November 28, 2025 10:32

marki1an reviewed Nov 28, 2025

View reviewed changes

remove duplicates

4cfbaeb

osulzhenko requested a review from marki1an November 28, 2025 11:23

marki1an approved these changes Nov 28, 2025

View reviewed changes

osulzhenko merged commit cedc939 into support-gpp-usnat-v2 Nov 28, 2025
1 check passed

osulzhenko deleted the functional-tests/support-gpp-usnat-v2 branch November 28, 2025 17:23

		.setMspaServiceProviderMode(MspaMode.YES)
		.setMspaServiceProviderMode(MspaMode.NO)


		import com.fasterxml.jackson.annotation.JsonValue

		enum DataActivity {


		class UsCaliforniaV1ChildSensitiveData {

		DataActivity childBlow13

		GppDataActivity childSensitive

		static UsColoradoV1ChildSensitiveData getDefault(GppDataActivity childSensitive = GppDataActivity.NOT_APPLICABLE) {

Tests: Support GPP USNat v2 #3766

Tests: Support GPP USNat v2 #3766

Uh oh!

Conversation

osulzhenko commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🔎 New Bid Adapter Checklist

🧪 Test plan

🏎 Quality check

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

osulzhenko commented Feb 18, 2025 •

edited

Loading