Skip to content

Test: suppressIBV in response correction module #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test: suppressIBV in response correction module #3789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a8eeb4
Add functional tests for
marki1an Feb 26, 2025
77a22de
Empty line
marki1an Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/test/groovy/org/prebid/server/functional/model/config/PbResponseCorrection.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.prebid.server.functional.model.config

import com.fasterxml.jackson.annotation.JsonProperty
import com.fasterxml.jackson.databind.PropertyNamingStrategies
import com.fasterxml.jackson.databind.annotation.JsonNaming
import groovy.transform.ToString
Expand All @@ -8,6 +9,8 @@ import groovy.transform.ToString
@JsonNaming(PropertyNamingStrategies.KebabCaseStrategy)
class PbResponseCorrection {

Boolean enabled
AppVideoHtml appVideoHtml
Boolean enabled
AppVideoHtml appVideoHtml
@JsonProperty("suppress-ibv")
SuppressIbv suppressInBannerVideo
}
14 changes: 14 additions & 0 deletions src/test/groovy/org/prebid/server/functional/model/config/SuppressIbv.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package org.prebid.server.functional.model.config

import com.fasterxml.jackson.databind.PropertyNamingStrategies
import com.fasterxml.jackson.databind.annotation.JsonNaming
import groovy.transform.ToString
import org.prebid.server.functional.model.bidder.BidderName

@ToString(includeNames = true, ignoreNulls = true)
@JsonNaming(PropertyNamingStrategies.LowerCaseStrategy)
class SuppressIbv {

Boolean enabled
List<BidderName> excludedBidders
}
3 changes: 3 additions & 0 deletions ...test/groovy/org/prebid/server/functional/model/response/auction/BidRejectionReason.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ enum BidRejectionReason {
RESPONSE_REJECTED_INVALID_CREATIVE(350),
RESPONSE_REJECTED_INVALID_CREATIVE_SIZE(351),
RESPONSE_REJECTED_INVALID_CREATIVE_NOT_SECURE(352),

RESPONSE_REJECTED_DUE_TO_IN_BANNER_VIDEO(353),

Comment on lines +26 to +28
Copy link
Collaborator

@osulzhenko osulzhenko Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a part of response_rejection group, no need of extra space

RESPONSE_REJECTED_ADVERTISER_BLOCKED(356)

@JsonValue
Expand Down
3 changes: 2 additions & 1 deletion src/test/groovy/org/prebid/server/functional/model/response/auction/SeatNonBid.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ package org.prebid.server.functional.model.response.auction
import com.fasterxml.jackson.databind.PropertyNamingStrategies
import com.fasterxml.jackson.databind.annotation.JsonNaming
import groovy.transform.ToString
import org.prebid.server.functional.model.bidder.BidderName

@ToString(includeNames = true, ignoreNulls = true)
@JsonNaming(PropertyNamingStrategies.LowerCaseStrategy)
class SeatNonBid {

String seat
BidderName seat
List<NonBid> nonBid
}
4 changes: 2 additions & 2 deletions src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,7 @@ class BidderParamsSpec extends BaseSpec {
["No match between the configured currencies and bidRequest.cur"]

def seatNonBid = response.ext.seatnonbid[0]
assert seatNonBid.seat == BidderName.GENERIC.value
assert seatNonBid.seat == BidderName.GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == REQUEST_BLOCKED_UNACCEPTABLE_CURRENCY

Expand Down Expand Up @@ -1230,7 +1230,7 @@ class BidderParamsSpec extends BaseSpec {
assert response.ext.seatnonbid.size() == 1

def seatNonBid = response.ext.seatnonbid[0]
assert seatNonBid.seat == BidderName.ALIAS.value
assert seatNonBid.seat == BidderName.ALIAS
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == REQUEST_BLOCKED_UNACCEPTABLE_CURRENCY

Expand Down
17 changes: 9 additions & 8 deletions src/test/groovy/org/prebid/server/functional/tests/SeatNonBidSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.prebid.server.functional.tests

import org.mockserver.model.HttpStatusCode
import org.prebid.server.functional.model.bidder.BidderName
import org.prebid.server.functional.model.config.AccountAuctionConfig
import org.prebid.server.functional.model.config.AccountBidValidationConfig
import org.prebid.server.functional.model.config.AccountConfig
Expand Down Expand Up @@ -57,7 +58,7 @@ class SeatNonBidSpec extends BaseSpec {
assert response.ext.seatnonbid.size() == 1

def seatNonBid = response.ext.seatnonbid[0]
assert seatNonBid.seat == GENERIC.value
assert seatNonBid.seat == BidderName.GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == ERROR_NO_BID

Expand All @@ -83,7 +84,7 @@ class SeatNonBidSpec extends BaseSpec {
assert response.ext.seatnonbid.size() == 1

def seatNonBid = response.ext.seatnonbid[0]
assert seatNonBid.seat == GENERIC.value
assert seatNonBid.seat == BidderName.GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == ERROR_INVALID_BID_RESPONSE
}
Expand All @@ -105,7 +106,7 @@ class SeatNonBidSpec extends BaseSpec {
assert response.ext.seatnonbid.size() == 1

def seatNonBid = response.ext.seatnonbid[0]
assert seatNonBid.seat == GENERIC.value
assert seatNonBid.seat == BidderName.GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == ERROR_BIDDER_UNREACHABLE
}
Expand Down Expand Up @@ -138,7 +139,7 @@ class SeatNonBidSpec extends BaseSpec {
assert response.ext.seatnonbid.size() == 1

def seatNonBid = response.ext.seatnonbid[0]
assert seatNonBid.seat == GENERIC.value
assert seatNonBid.seat == BidderName.GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == RESPONSE_REJECTED_INVALID_CREATIVE_SIZE
}
Expand Down Expand Up @@ -169,7 +170,7 @@ class SeatNonBidSpec extends BaseSpec {
assert response.ext.seatnonbid.size() == 1

def seatNonBid = response.ext.seatnonbid[0]
assert seatNonBid.seat == GENERIC.value
assert seatNonBid.seat == BidderName.GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == RESPONSE_REJECTED_INVALID_CREATIVE_NOT_SECURE

Expand Down Expand Up @@ -216,7 +217,7 @@ class SeatNonBidSpec extends BaseSpec {
assert response.ext.seatnonbid.size() == 1

def seatNonBid = response.ext.seatnonbid[0]
assert seatNonBid.seat == GENERIC.value
assert seatNonBid.seat == BidderName.GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == ERROR_NO_BID

Expand Down Expand Up @@ -277,7 +278,7 @@ class SeatNonBidSpec extends BaseSpec {
assert seatNonBids.size() == 1

def seatNonBid = seatNonBids[0]
assert seatNonBid.seat == GENERIC.value
assert seatNonBid.seat == BidderName.GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == ERROR_TIMED_OUT
}
Expand All @@ -301,7 +302,7 @@ class SeatNonBidSpec extends BaseSpec {
assert seatNonBids.size() == 1

def seatNonBid = seatNonBids[0]
assert seatNonBid.seat == GENERIC.value
assert seatNonBid.seat == BidderName.GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == REQUEST_BLOCKED_UNSUPPORTED_MEDIA_TYPE

Expand Down
2 changes: 1 addition & 1 deletion ...t/groovy/org/prebid/server/functional/tests/module/ortb2blocking/Ortb2BlockingSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1521,7 +1521,7 @@ class Ortb2BlockingSpec extends ModuleBaseSpec {
assert response.ext.seatnonbid.size() == 1

def seatNonBid = response.ext.seatnonbid[0]
assert seatNonBid.seat == ErrorType.GENERIC.value
assert seatNonBid.seat == GENERIC
assert seatNonBid.nonBid[0].impId == bidRequest.imp[0].id
assert seatNonBid.nonBid[0].statusCode == RESPONSE_REJECTED_ADVERTISER_BLOCKED
}
Expand Down
Loading
Loading